Apply flake8-logging-format changes to tests #24931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:Apache
provider:google
josh-fell
commented
Jul 8, 2022
josh-fell
commented
Jul 8, 2022
potiuk
reviewed
Jul 12, 2022
potiuk
reviewed
Jul 12, 2022
potiuk
reviewed
Jul 12, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
General comment - we should get rid of the try/except/log here and replace them with fixture. The best code is no code :)
josh-fell
force-pushed
the
flake8-logging-format-tests
branch
from
f6fdb9e to
2de4b89
Compare
josh-fell
force-pushed
the
flake8-logging-format-tests
branch
from
2de4b89 to
d7c1cf5
Compare
josh-fell
force-pushed
the
flake8-logging-format-tests
branch
from
d7c1cf5 to
47f68e1
Compare
potiuk
approved these changes
Aug 4, 2022
potiuk
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #23597 #24910
This is some pre-work for hopefully including the flake8-logging-format extension in CI. There are roughly 88 file changes so splitting these up into smaller chunks.
After the initial sweeps are completed we can do a final pass when formally implementing the extension in CI.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.