Refactor and fix AWS secret manager invalid exception #24898
Conversation
Co-authored-by: gitstart-airflow <airflow@gitstart.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Vannes Wijaya <42536665+vanneswijaya@users.noreply.github.com> Co-authored-by: Ekene Izukanne <ekeneizukanne@gmail.com>
boring-cyborg
bot
added
area:providers
area:secrets
provider:amazon
|
You will have to rebase (static checks are failing) but also wait until #24901 is merged (it should solve the test failures - my mistake introduced yesterday). |
|
OK. you can rebase now @gitstart-airflow |
|
(and fix the static check along the way. I recommend pre-commit, it will do it for you. |
| return None | ||
| except self.client.exceptions.InvalidRequestException: | ||
| self.log.debug( | ||
| f"InvalidRequestException: {error_msg}", |
There was a problem hiding this comment.
Can you change the the logging statements to use %-formatting instead of f-strings please? This makes sure that the string formatting is deferred until it cannot be avoided. This is a helpful reference which hopefully explains the practice here.
There was a problem hiding this comment.
@josh-fell Finally I got to automate this check. I really do not like wasting mental capacity for things that can be automated during review :) #24910
Co-authored-by: gitstart-airflow <airflow@gitstart.com> Co-authored-by: gitstart-bot <gitstart@users.noreply.github.com> Co-authored-by: Ekene Izukanne <ekeneizukanne@gmail.com> Co-authored-by: Vannes Wijaya <42536665+vanneswijaya@users.noreply.github.com>
4 participants
closes: #24773
related: #24773
This PR removes the invalid AccessDeniedException in get_secret_value and handle more exceptions.
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.