Skip to content

Migrate Microsoft example DAGs to new design #22452 - winrm #24140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Jun 3, 2022
Merged

Migrate Microsoft example DAGs to new design #22452 - winrm #24140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab17d26
Migrate Microsoft example DAGs to new design #22452 - winrm
chethanuk Jun 2, 2022
ca24cef
Fix static checks
chethanuk Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions airflow/providers/microsoft/winrm/example_dags/__init__.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion docs/apache-airflow-providers-microsoft-winrm/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Content
:maxdepth: 1
:caption: Resources

Example DAGs <https://github.com/apache/airflow/tree/main/airflow/providers/microsoft/winrm/example_dags>
Example DAGs <https://github.com/apache/airflow/tree/main/tests/system/providers/microsoft/winrm>
PyPI Repository <https://pypi.org/project/apache-airflow-providers-microsoft-winrm/>
Installing from sources <installing-providers-from-sources>

Expand Down
4 changes: 2 additions & 2 deletions docs/apache-airflow-providers-microsoft-winrm/operators.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ use the WinRMOperator to execute commands on a given remote host using the winrm

create a hook

.. exampleinclude:: /../../airflow/providers/microsoft/winrm/example_dags/example_winrm.py
.. exampleinclude:: /../../tests/system/providers/microsoft/winrm/example_winrm.py
:language: python
:dedent: 4
:start-after: [START create_hook]
:end-before: [END create_hook]

Run the operator, pass the hook, and pass a command to do something

.. exampleinclude:: /../../airflow/providers/microsoft/winrm/example_dags/example_winrm.py
.. exampleinclude:: /../../tests/system/providers/microsoft/winrm/example_winrm.py
:language: python
:dedent: 4
:start-after: [START run_operator]
Expand Down
18 changes: 17 additions & 1 deletion ...osoft/winrm/example_dags/example_winrm.py → ...roviders/microsoft/winrm/example_winrm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"""
This is an example dag for using the WinRMOperator.
"""
import os
from datetime import datetime, timedelta

from airflow import DAG
Expand All @@ -34,11 +35,15 @@
from airflow.operators.empty import EmptyOperator
except ModuleNotFoundError:
from airflow.operators.dummy import DummyOperator as EmptyOperator # type: ignore

from airflow.providers.microsoft.winrm.hooks.winrm import WinRMHook
from airflow.providers.microsoft.winrm.operators.winrm import WinRMOperator

ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
DAG_ID = "POC_winrm_parallel"

with DAG(
dag_id='POC_winrm_parallel',
dag_id=DAG_ID,
schedule_interval='0 0 * * *',
start_date=datetime(2021, 1, 1),
dagrun_timeout=timedelta(minutes=60),
Expand All @@ -61,3 +66,14 @@
# [END run_operator]

[t1, t2, t3] >> run_this_last

from tests.system.utils.watcher import watcher

# This test needs watcher in order to properly mark success/failure
# when "tearDown" task with trigger rule is part of the DAG
list(dag.tasks) >> watcher()

from tests.system.utils import get_test_run # noqa: E402

# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest)
test_run = get_test_run(dag)