Skip to content

Rename Permissions to Permission Pairs. #24065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhtimmins merged 1 commit into from
Jun 2, 2022
Merged

Rename Permissions to Permission Pairs. #24065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/www/fab_security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ def register_views(self):
if self.appbuilder.app.config.get("FAB_ADD_SECURITY_PERMISSION_VIEWS_VIEW", True):
self.appbuilder.add_view(
self.permissionmodelview,
"Permissions",
"Permission Pairs",
Copy link
Member

@ashb ashb Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this ever get shown anywhere to a user? Perhaps in the CRUD screens to manage permissions?

Copy link
Contributor Author

@jhtimmins jhtimmins Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashb That's correct.

Copy link
Member

@jedcunningham jedcunningham Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't get shown to the user, the label 2 lines down is what is shown 👍

Copy link
Contributor Author

@jhtimmins jhtimmins Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedcunningham I believe that the label is what's shown in the dropdown, and "permission pairs" is what shows up in the admin view of permissions.

Copy link
Member

@jedcunningham jedcunningham Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, you are totally right! Thanks 🍺

Copy link
Member

@uranusjr uranusjr Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there’s a better name than Permission Pairs (which doesn’t explain much on its own).

Copy link
Contributor Author

@jhtimmins jhtimmins Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an alternative suggestion? This is unlikely to be seen by users (since it's automatically added to admin roles).

Copy link
Member

@uranusjr uranusjr Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have a better suggestion 😞

icon="fa-link",
label=_("Permissions"),
category="Security",
Expand Down