Skip to content

Fix breeze failures when there is no buildx installed on Mac #23988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
May 28, 2022
Merged

Fix breeze failures when there is no buildx installed on Mac #23988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions dev/breeze/src/airflow_breeze/utils/run_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,22 +287,18 @@ def check_if_buildx_plugin_installed(verbose: bool) -> bool:
:param verbose: print commands when running
:return True if the buildx plugin is installed.
"""
is_buildx_available = False
check_buildx = ['docker', 'buildx', 'version']
docker_buildx_version_result = run_command(
check_buildx,
verbose=verbose,
no_output_dump_on_exception=True,
capture_output=True,
text=True,
check=False,
)
if (
docker_buildx_version_result
and docker_buildx_version_result.returncode == 0
and docker_buildx_version_result.stdout != ''
):
is_buildx_available = True
return is_buildx_available
if docker_buildx_version_result.returncode == 0:
return True
return False


def prepare_base_build_command(image_params: _CommonBuildParams, verbose: bool) -> List[str]:
Expand Down