Skip to content

Fix Amazon EKS example DAG raises warning during Imports #23849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
May 22, 2022
Merged

Fix Amazon EKS example DAG raises warning during Imports #23849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fba81e4
fix Amazon EKS example DAG raises warning
Dark-Knight11 May 21, 2022
8d77201
Update airflow/providers/amazon/aws/operators/eks.py
eladkal May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions airflow/providers/amazon/aws/operators/eks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,23 +275,23 @@ def __init__(
self.create_nodegroup_kwargs = create_nodegroup_kwargs or {}
self.aws_conn_id = aws_conn_id
self.region = region
nodegroup_subnets_list: List[str] = []
if isinstance(nodegroup_subnets, str):
if nodegroup_subnets != "":
self.nodegroup_subnets = nodegroup_subnets
super().__init__(**kwargs)

def execute(self, context: 'Context'):
if isinstance(self.nodegroup_subnets, str):
nodegroup_subnets_list: List[str] = []
if self.nodegroup_subnets != "":
try:
nodegroup_subnets_list = cast(List, literal_eval(nodegroup_subnets))
nodegroup_subnets_list = cast(List, literal_eval(self.nodegroup_subnets))
except ValueError:
self.log.warning(
"The nodegroup_subnets should be List or string representing "
"Python list and is %s. Defaulting to []",
nodegroup_subnets,
self.nodegroup_subnets,
)
else:
nodegroup_subnets_list = nodegroup_subnets
self.nodegroup_subnets = nodegroup_subnets_list
super().__init__(**kwargs)
self.nodegroup_subnets = nodegroup_subnets_list

def execute(self, context: 'Context'):
eks_hook = EksHook(
aws_conn_id=self.aws_conn_id,
region_name=self.region,
Expand Down