Skip to content

Fixed test and remove pytest.mark.xfail for test_exc_tb #23650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
May 11, 2022
Merged

Fixed test and remove pytest.mark.xfail for test_exc_tb #23650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd1661
Fixed test and remove pytest.mark.xfail for test_exc_tb
subkanthi May 11, 2022
ea2a5b3
Merge branch 'main' into remove_xfail_test_secrets_marker
subkanthi May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/utils/log/test_secrets_masker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ def test_exception_not_raised(self, logger, caplog):
"""
)

@pytest.mark.xfail(reason="Cannot filter secrets in traceback source")
def test_exc_tb(self, logger, caplog):
"""
Show it is not possible to filter secrets in the source.
Expand Down Expand Up @@ -142,7 +141,7 @@ def test_exc_tb(self, logger, caplog):
ERROR Err
Traceback (most recent call last):
File ".../test_secrets_masker.py", line {line}, in test_exc_tb
raise RuntimeError("Cannot connect to user:***)
raise RuntimeError("Cannot connect to user:password")
RuntimeError: Cannot connect to user:***
"""
)
Expand Down