Replaced all days_ago functions with datetime functions #21796

Dev232001 · 2022-02-24T16:25:57Z

closes: #21683
Replace all the days_ago functions with datetime functions as asked in the issue

boring-cyborg · 2022-02-24T16:26:00Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: [email protected]
Slack: https://s.apache.org/airflow-slack

eladkal · 2022-02-24T16:37:34Z

tests/dags/test_example_bash_operator.py

 from datetime import timedelta
-
+import datetime


If from datetime import timedelta already present why not doing
from datetime import datetime, timedelta

and use datetime(2022,1,1) rather than datetime.datetime(2022,1,1)

oh! didn't see that there. There are a lot of files and I checked each one manually for maximum efficiency so forgot to use some of the already present libraries. If you want I can change them again quickly

josh-fell · 2022-02-24T17:16:48Z

tests/api_connexion/endpoints/test_extra_link_endpoint.py

            dag_id="TEST_DAG_ID",
            default_args=dict(
-                start_date=days_ago(2),
+                start_date=datetime.datetime(2022, 1, 1),


I suspect we should move away from datetime.datetime to pendulum.datetime for start_date values in unit tests too based on the conversation in #21646. @eladkal WDYT?

Do you mean just for tests or also for example dags?
I have no objection.

For unit tests as well as example DAGs for consistency in tests, examples, docs, etc. The core example DAGs have been transitioned but the provider ones haven't yet.

I too think pendulum is a better alternative for datetime

Then yeah lets do that

Of course! Not a problem at all

80a6ae5

Another pull request after swapping datetime with pendulum where start dates are involved

For tests specifically I actually prefer datetime.datetime since it better ensures we are coercing timezones correctly internally.

That one is also done in the previous pull request. I guess my task is done so please let me know if there is anything more to update.

`days_ago` is going to be deprecated and removed. Vote: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk PR: apache/airflow#21796 Issue: apache/airflow#21683

uranusjr · 2022-03-01T01:33:34Z

Please fix the static check failures.

`days_ago` is going to be deprecated and removed. Vote: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk PR: apache/airflow#21796 Issue: apache/airflow#21683

Dev232001 · 2022-03-01T05:18:32Z

Sure, Thanks

…

On Tue, Mar 1, 2022, 7:03 AM Tzu-ping Chung ***@***.***> wrote: Please fix the static check failures. — Reply to this email directly, view it on GitHub <#21796 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXEWNKDPYBCSGSCMKS544FTU5VXXTANCNFSM5PH3L2JA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

Dev232001 · 2022-03-04T15:12:00Z

I tried solving the static checks but wasn't able to do so. Can you help me on what is wrong exactly

Bowrna · 2022-03-06T09:46:42Z

@Dev232001 run pre-commit run --all-files locally in your machine to fix the black formatting, sorting issues. There are a few duplicate imports too. If you run the command locally it will point to the files with those errors. you can fix it and commit to avoid static check issues.

Alternatively you can run static check via Breeze too. Under the hood this runs pre-commit too.
https://github.com/apache/airflow/blob/main/BREEZE.rst#running-static-checks

eladkal · 2022-03-18T12:03:44Z

@Dev232001 do you need further help?

github-actions · 2022-05-03T00:11:38Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

uranusjr · 2022-05-03T22:40:14Z

Superceded by #23237.

`days_ago` is going to be deprecated and removed. Vote: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk PR: apache/airflow#21796 Issue: apache/airflow#21683

Replaced all days_ago functions with datetime functions

eb73c4e

boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI area:core-operators area:Scheduler including HA (high availability) scheduler labels Feb 24, 2022

Dev232001 mentioned this pull request Feb 24, 2022

Remove all usages of days_ago from test suite #21683

Closed

1 task

eladkal reviewed Feb 24, 2022

View reviewed changes

josh-fell reviewed Feb 24, 2022

View reviewed changes

github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 3, 2022

uranusjr closed this May 3, 2022

Replaced all days_ago functions with datetime functions #21796

Replaced all days_ago functions with datetime functions #21796

Uh oh!

Conversation

Dev232001 commented Feb 24, 2022 • edited by eladkal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boring-cyborg bot commented Feb 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uranusjr commented Mar 1, 2022

Uh oh!

Dev232001 commented Mar 1, 2022 via email

Uh oh!

Dev232001 commented Mar 4, 2022

Uh oh!

Bowrna commented Mar 6, 2022

Uh oh!

eladkal commented Mar 18, 2022

Uh oh!

github-actions bot commented May 3, 2022

Uh oh!

uranusjr commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Dev232001 commented Feb 24, 2022 •

edited by eladkal

Loading