The Pyarrow limitation in install_requires is not needed. #12683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added to make snowflake happy, but it is not needed as package requirement in fact and google provider complains when the version of pyarrow is too low. Also when PyArrow limitation is removed, we have to limit the importlib_resources library back.
ashb
requested changes
Nov 28, 2020
ashb
approved these changes
Nov 28, 2020
github-actions
bot
added
the
okay to merge
|
The PR is ready to be merged. No tests are needed! |
mik-laj
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added to make snowflake happy, but it is not needed as
package requirement in fact and google provider complains when
the version of pyarrow is too low.
Also when PyArrow limitation is removed, we have to limit
the importlib_resources library back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.