Skip to content

Commit

Permalink
feat(task_sdk): remove data_interval_start, data_interval_end, prev_d…
Browse files Browse the repository at this point in the history
…ata_interval_start_success, prev_data_interval_end_success for dag_run that has no data_interval
  • Loading branch information
Lee-W committed Feb 11, 2025
1 parent 555d3f2 commit 7e3cde7
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions task_sdk/src/airflow/sdk/execution_time/task_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,16 +155,8 @@ def get_template_context(self) -> Context:
context_from_server: Context = {
# TODO: Assess if we need to pass these through timezone.coerce_datetime
"dag_run": dag_run, # type: ignore[typeddict-item] # Removable after #46522
"data_interval_end": dag_run.data_interval_end,
"data_interval_start": dag_run.data_interval_start,
"task_instance_key_str": f"{self.task.dag_id}__{self.task.task_id}__{dag_run.run_id}",
"task_reschedule_count": self._ti_context_from_server.task_reschedule_count,
"prev_data_interval_start_success": lazy_object_proxy.Proxy(
lambda: get_previous_dagrun_success(self.id).data_interval_start
),
"prev_data_interval_end_success": lazy_object_proxy.Proxy(
lambda: get_previous_dagrun_success(self.id).data_interval_end
),
"prev_start_date_success": lazy_object_proxy.Proxy(
lambda: get_previous_dagrun_success(self.id).start_date
),
Expand All @@ -174,6 +166,20 @@ def get_template_context(self) -> Context:
}
context.update(context_from_server)

if dag_run.data_interval_start and dag_run.data_interval_end:
context.update(
{
"data_interval_end": dag_run.data_interval_end,
"data_interval_start": dag_run.data_interval_start,
"prev_data_interval_start_success": lazy_object_proxy.Proxy(
lambda: get_previous_dagrun_success(self.id).data_interval_start
),
"prev_data_interval_end_success": lazy_object_proxy.Proxy(
lambda: get_previous_dagrun_success(self.id).data_interval_end
),
}
)

if logical_date := dag_run.logical_date:
ds = logical_date.strftime("%Y-%m-%d")
ds_nodash = ds.replace("-", "")
Expand Down

0 comments on commit 7e3cde7

Please sign in to comment.