Fix Issue 1691 - MERGE incorrectly creates multiple vertices (#1718) #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1718) Fixed issue 1691 where MERGE would incorrectly create multiple vertices. This only occurred when MERGE was being driven by a previous clause. NOTE: To be more correct, the issue is with creating duplicate paths. The reason this happened was due to the visibility of tuples that were created during the MERGE instance. It is not possible to add them in to be rescanned. Because of this limitation, it required adding the ability to MERGE to know what path an instance had already created. Added regression tests. Modified the following files to add missing functionality in PG13 and below branches. Specifically adding the function datum_image_hash. modified: src/backend/executor/cypher_utils.c modified: src/include/executor/cypher_utils.h Resolved Conflicts: (due to differences between PG13 & PG12) src/backend/executor/cypher_merge.c Modified datum_image_hash to use hash_any. Changed datum_image_eq to datumIsEqual as the former doesn't exist in PG11.
jrgemignani
requested review from
dehowef,
MuhammadTahaNaveed,
rafsun42 and
Zainab-Saad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 1691 where MERGE would incorrectly create multiple vertices. This only occurred when MERGE was being driven by a previous clause.
NOTE: To be more correct, the issue is with creating duplicate
paths.
The reason this happened was due to the visibility of tuples that were created during the MERGE instance. It is not possible to add them in to be rescanned.
Because of this limitation, it required adding the ability to MERGE to know what path an instance had already created.
Added regression tests.
Modified the following files to add missing functionality in PG13 and below branches. Specifically adding the function datum_image_hash.
Resolved Conflicts: (due to differences between PG13 & PG12)
src/backend/executor/cypher_merge.c
Modified datum_image_hash to use hash_any.
Changed datum_image_eq to datumIsEqual as the former doesn't exist in PG11.