-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REGTYPEOID to toString function #1036
Conversation
Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE. For example - psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$ MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x)) $$) as (a agtype); a ---------- "agtype" "agtype" "agtype" (3 rows) Added regression tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There is one suggestion. It might be useful to have a function that returns the actual type of agtype
as well (i.e. edge
, vertex
etc.). Do we have such functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE. For example - psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$ MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x)) $$) as (a agtype); a ---------- "agtype" "agtype" "agtype" (3 rows) Added regression tests.
Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE. For example - psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$ MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x)) $$) as (a agtype); a ---------- "agtype" "agtype" "agtype" (3 rows) Added regression tests.
Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE. For example - psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$ MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x)) $$) as (a agtype); a ---------- "agtype" "agtype" "agtype" (3 rows) Added regression tests.
Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE. For example - psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$ MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x)) $$) as (a agtype); a ---------- "agtype" "agtype" "agtype" (3 rows) Added regression tests.
Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE. For example - psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$ MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x)) $$) as (a agtype); a ---------- "agtype" "agtype" "agtype" (3 rows) Added regression tests.
Added the
REGTYPEOID
to thetoString
function. This will help in debugging by allowingpg_typeof
to work with AGE.For example -
Added regression tests.