Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REGTYPEOID to toString function #1036

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jrgemignani
Copy link
Contributor

@jrgemignani jrgemignani commented Jul 13, 2023

Added the REGTYPEOID to the toString function. This will help in debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.

Added the REGTYPEOID to the toString function. This will help in
debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.
Copy link
Member

@rafsun42 rafsun42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

There is one suggestion. It might be useful to have a function that returns the actual type of agtype as well (i.e. edge, vertex etc.). Do we have such functions?

Copy link
Member

@dehowef dehowef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dehowef dehowef merged commit f59f9e4 into apache:master Jul 13, 2023
jrgemignani added a commit to jrgemignani/age that referenced this pull request Jul 17, 2023
Added the REGTYPEOID to the toString function. This will help in
debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Jul 17, 2023
Added the REGTYPEOID to the toString function. This will help in
debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.
M4rcxs pushed a commit to M4rcxs/age that referenced this pull request Jul 18, 2023
Added the REGTYPEOID to the toString function. This will help in
debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.
muhammadshoaib pushed a commit to muhammadshoaib/age that referenced this pull request Jul 20, 2023
Added the REGTYPEOID to the toString function. This will help in
debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.
MuhammadTahaNaveed pushed a commit to MuhammadTahaNaveed/age that referenced this pull request Aug 24, 2023
Added the REGTYPEOID to the toString function. This will help in
debugging by allowing pg_typeof to work with AGE.

For example -

psql-13.9-5432-pgsql=# SELECT * FROM cypher('graph',$$
     MATCH ()<-[x *]-() RETURN toString(pg_catalog.pg_typeof(x))
$$) as (a agtype);
    a
----------
 "agtype"
 "agtype"
 "agtype"
(3 rows)

Added regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants