[AMQ-9537] Update user-guide.html #1266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jetty demo configuration is using jetty settings shipped with the broker
jbonofre
reviewed
Jul 22, 2024
| @@ -98,7 +98,7 @@ <h2>Access the web demos</h2> | |||
| </p> | |||
| <pre> | |||
| cd bin | |||
| activemq.bat console xbean:examples/conf/activemq-demo.xml | |||
| activemq.bat start xbean:../examples/conf/activemq-demo.xml | |||
There was a problem hiding this comment.
NB: activemq console is actually valid (at least for Unix shell script). activemq.bat doesn't really take any action arg. Maybe we should clean the arg.
There was a problem hiding this comment.
Thank you for the review!
You are correct that the activemq.bat file does not take any arguments directly, but it does pass the provided arguments to the jar using %*. For reference, see this line:
Running
activemq.bat without start argument will not start the broker.
jbonofre
requested changes
Jul 22, 2024
| some demos Include this file in your configuration to enable ActiveMQ web components | ||
| e.g. <import resource="jetty.xml"/> | ||
| --> | ||
| <beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
There was a problem hiding this comment.
I would completely remove this file as it's ActiveMQ 5.x specific (not 6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated things I've noticed that did not work when following the guide:
saved the 5.x demo config for reference.