Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [#70] Convert to junit5 #8

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Dec 7, 2023

  • openwire-core converted and all tests passing
  • openwire-generator converted and all tests passing
  • openwire-interop converted and all tests passing

Reviewer notes:

  • junit5 does not support parameterized tests at class or beforeEach level
  • junit5 asserts move the 'message' argument to the end... pay close attention to ensure test asserts are correct when reviewing
  • DataStructureTestSupport renamed the class defined method assertEquals(object, object) to assertEqualsOpenwire(..) b/c it is re-entrant and causes confusion with the method-local fully qualified junit5 assertEquals(obj, obj)
  • Note: Test coverage of openwire-core (by itself) is very low

@mattrpav mattrpav self-assigned this Dec 7, 2023
@mattrpav mattrpav force-pushed the openwire-70 branch 3 times, most recently from 3903b0e to 0f0f0d1 Compare December 8, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant