fixes SplitIT.bulkImportThatCantSplitHangsCompaction #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was making a incorrect assumption that a table with no splits and data for a single row could not split. What would actually happen is that the table would split once for the single row in the data and then still need to split but be unable to. Added single split at table creation time to fix this. Before these changes the test would add data to a table and then immediately check that its splits were zero. The table would eventually split, but usually the check in the test would happen prior to this. This race condition in the test hid the flawed assumption in the test. Added a wait to the test to fix this.
dlmarion
approved these changes
Dec 7, 2024
cshannon
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was making a incorrect assumption that a table with no splits and data for a single row could not split. What would actually happen is that the table would split once for the single row in the data and then still need to split but be unable to. Added single split at table creation time to fix this.
Before these changes the test would add data to a table and then immediately check that its splits were zero. The table would eventually split, but usually the check in the test would happen prior to this. This race condition in the test hid the flawed assumption in the test. Added a wait to the test to fix this.