fixes slow bulk import with many tablets and file #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk import code was reading all tablets in the bulk import range for each range being bulk imported. This resulted in O(N^2) metadata table scans which made really large bulk imports really slow. Added a new test that bulk imports thousands of files into thousands of tablets. Running this test w/o the fixes in this PR the following time is seen for the fate step. ``` DEBUG: Running LoadFiles.isReady() FATE:USER:6320e73d-e661-4c66-bf25-c0c27a0a79d5 took 289521 ms and returned 0 ``` With this fix in this PR seeing the following times for the new test, so goes from 290s to 1.2s. ``` DEBUG: Running LoadFiles.isReady() FATE:USER:18e52fc2-5876-4b01-ba7b-3b3c099a82be took 1225 ms and returned 0 ``` This bug does not seem to exists in 2.1 or 3.1. Did not run the test though, may be worthwhile to backport the test.
dlmarion
reviewed
Nov 8, 2024
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java
Show resolved
Hide resolved
dlmarion
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk import code was reading all tablets in the bulk import range for each range being bulk imported. This resulted in O(N^2) metadata table scans which made really large bulk imports really slow.
Added a new test that bulk imports thousands of files into thousands of tablets. Running this test w/o the fixes in this PR the following time is seen for the fate step.
With this fix in this PR seeing the following times for the new test, so goes from 290s to 1.2s.
This bug does not seem to exists in 2.1 or 3.1. Did not run the test though, may be worthwhile to backport the test.