Modified cluster.yaml to support num servers per group #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified cluster.yaml to support specifying number servers per group for compactors, sservers, and tservers. This was supported previously, but the implementation was different and the information was not as tightly coupled in the yaml file. Closes apache#5032
|
Draft because I have not tested locally yet. |
|
I'm not sure what change |
keith-turner
reviewed
Nov 8, 2024
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Nov 8, 2024
|
Would a 2.1 cluster.yaml file fail to parse w/ a clean message w/ these changes? |
I don't think the compactor/sserver/tserver sections would work. I can test with a 2.1 config and make sure a good error is thrown. |
ddanielr
reviewed
Nov 9, 2024
| tserver: | ||
| default: | ||
| - localhost | ||
|
|
There was a problem hiding this comment.
Should this also have a compaction-coordinator section?
There was a problem hiding this comment.
I don't think so, scan servers and external compactions are optional and experimental in 2.1. This is a minimal config for 2.1
ddanielr
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified cluster.yaml to support specifying number servers per group for compactors, sservers, and tservers. This was supported previously, but the implementation was different and the information was not as tightly coupled in the yaml file.
Closes #5032