Skip to content

Commit

Permalink
Fix #1792 flaky/broken GcMetricsIT
Browse files Browse the repository at this point in the history
Rewrite portions of GcMetricsIT to improve its reliability and to add
comments and rename methods to make it more clear how it is intended to
work, so it's easier to debug in future.

Also use daemon threads for the tailer, and ensure it is started
consistently (using a dedicated method) and closed properly when done.

Remove unnecessary catching of exceptions, and allow them to be thrown
from the tests instead, because they will be handled by the test
framework.
  • Loading branch information
ctubbsii committed Dec 17, 2020
1 parent 8433b58 commit 0773baa
Show file tree
Hide file tree
Showing 5 changed files with 185 additions and 278 deletions.
Loading

0 comments on commit 0773baa

Please sign in to comment.