fix(plugin-chart-table): ignore duplicate percent metrics#994
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/E23AKHHBypVdDBLHSswbF4uR7tak |
|
Please ignore the bad branch name. |
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
=======================================
Coverage 27.94% 27.94%
=======================================
Files 413 413
Lines 8523 8523
Branches 1204 1204
=======================================
Hits 2382 2382
Misses 5987 5987
Partials 154 154
Continue to review full report at Codecov.
|
4d774bc to
3ac5dab
Compare
| }; | ||
|
|
||
| export default cachedBuildQuery; | ||
| export default cachedBuildQuery(); |
There was a problem hiding this comment.
I also changed how the default buildQuery function is exported.
cc @simcha90
🐛 Bug Fix
Silently ignore duplicate percent metrics.
Currently we do this for metrics, but adding percent metrics with the same name may still cause an error. This fixes it.
Before
After