Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

Conversation

@maloun96
Copy link
Contributor

@maloun96 maloun96 commented Mar 4, 2021

Add min and height for the heatmap. Hide Y labels and X label when you reach the minimum

Screen.Recording.2021-03-03.at.15.09.51.mov
Screen.Recording.2021-03-03.at.15.09.07.mov
Screen.Recording.2021-03-04.at.10.42.31.mov

@maloun96 maloun96 requested a review from a team as a code owner March 4, 2021 08:09
@vercel
Copy link

vercel bot commented Mar 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/FnG1Q8j6xPDF7id19r8gG3udTmg9
✅ Preview: https://superset-ui-git-fork-maloun96-heatmap-responsive-2-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #989 (6ea8223) into master (15a718a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   28.10%   28.02%   -0.09%     
==========================================
  Files         412      412              
  Lines        8411     8436      +25     
  Branches     1193     1193              
==========================================
  Hits         2364     2364              
- Misses       5894     5919      +25     
  Partials      153      153              
Impacted Files Coverage Δ
plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a718a...6ea8223. Read the comment docs.

@maloun96
Copy link
Contributor Author

maloun96 commented Mar 4, 2021

@rusackas @villebro @junlincc

@maloun96
Copy link
Contributor Author

maloun96 commented Mar 5, 2021

Screen.Recording.2021-03-05.at.14.45.19.mov

Heatmap responsive in storybook!

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works really nicely, a major improvement over the old non-responsive one. One minor observation: I'm not sure we need a separate "Basic" vs "Resizable" story. Let's just make "Basic" and "With Null Data" both resizable and skip the "Resizable" one.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up task for the backlog, it would be nice to make the jsx tab show the child component instead of <ResizableChartDemo /> (would remove the need for a separate "Basic" vs "Resizable" story).

@villebro villebro merged commit b28270e into apache-superset:master Mar 8, 2021
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
* feat: responsive heatmap

* Rotate labels

* Update story for heatmap chart

* Add for withNullData chart

* Resizable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants