-
Notifications
You must be signed in to change notification settings - Fork 267
feat: responsive heatmap #989
feat: responsive heatmap #989
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/FnG1Q8j6xPDF7id19r8gG3udTmg9 |
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 28.10% 28.02% -0.09%
==========================================
Files 412 412
Lines 8411 8436 +25
Branches 1193 1193
==========================================
Hits 2364 2364
- Misses 5894 5919 +25
Partials 153 153
Continue to review full report at Codecov.
|
Screen.Recording.2021-03-05.at.14.45.19.movHeatmap responsive in storybook! |
villebro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works really nicely, a major improvement over the old non-responsive one. One minor observation: I'm not sure we need a separate "Basic" vs "Resizable" story. Let's just make "Basic" and "With Null Data" both resizable and skip the "Resizable" one.
villebro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up task for the backlog, it would be nice to make the jsx tab show the child component instead of <ResizableChartDemo /> (would remove the need for a separate "Basic" vs "Resizable" story).
* feat: responsive heatmap * Rotate labels * Update story for heatmap chart * Add for withNullData chart * Resizable
Add min and height for the heatmap. Hide Y labels and X label when you reach the minimum
Screen.Recording.2021-03-03.at.15.09.51.mov
Screen.Recording.2021-03-03.at.15.09.07.mov
Screen.Recording.2021-03-04.at.10.42.31.mov