-
Notifications
You must be signed in to change notification settings - Fork 267
feat: add BE pagination to table with pages #985
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/HwVs8e7qGyPHcTRTZTtXCxRSk7RF |
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 28.10% 28.03% -0.08%
==========================================
Files 412 412
Lines 8411 8436 +25
Branches 1193 1199 +6
==========================================
+ Hits 2364 2365 +1
- Misses 5894 5917 +23
- Partials 153 154 +1
Continue to review full report at Codecov.
|
villebro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass comments
villebro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM to me - I defer to @ktmud to sign off on this as he has most context with the table chart and requested some changes.
ktmud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one suggestion on reusing typing.
packages/superset-ui-core/src/chart/registries/ChartBuildQueryRegistrySingleton.ts
Show resolved
Hide resolved
| export type BuildQuery<T = any> = ( | ||
| formData: T, | ||
| options?: { | ||
| extras?: { | ||
| cachedChanges?: any; | ||
| }; | ||
| hooks?: { | ||
| setDataMask: SetDataMaskHook; | ||
| setCachedChanges: (newChanges: any) => void; | ||
| }; | ||
| }, | ||
| ) => QueryContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's possible to reuse BuildQueryFunction here:
| export type BuildQuery<T = any> = ( | |
| formData: T, | |
| options?: { | |
| extras?: { | |
| cachedChanges?: any; | |
| }; | |
| hooks?: { | |
| setDataMask: SetDataMaskHook; | |
| setCachedChanges: (newChanges: any) => void; | |
| }; | |
| }, | |
| ) => QueryContext; | |
| type BuildQuery = BuildQueryFunction<QueryFormData & JsonObject>; |
You just provide a more relaxed FormData type.
🏆 Enhancements
!Requires: https://github.com/apache/superset/pull/13417/files
This PR:
📜 Documentation
Screen.Recording.2021-03-02.at.15.46.46.mov