refactor(chart-controls): improve typing and file organization#962
refactor(chart-controls): improve typing and file organization#962
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/j0lpc9ulv |
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 27.70% 27.70%
=======================================
Files 401 401
Lines 8255 8255
Branches 1143 1143
=======================================
Hits 2287 2287
Misses 5831 5831
Partials 137 137
Continue to review full report at Codecov.
|
576c981 to
9de06e6
Compare
9de06e6 to
f1dad49
Compare
|
|
||
| export { default as __hack_reexport_chart_Base } from './types/Base'; | ||
| export { default as __hack_reexport_chart_TransformFunction } from './types/TransformFunction'; | ||
| export { default as __hack_reexport_chart_QueryResponse } from './types/QueryResponse'; |
espressoroaster
left a comment
There was a problem hiding this comment.
From an offline conversation with Jesse, export default {}; is a hack solution for re-exporting * from pure type files that don't contain real JavaScript variables.
Jesse explained that there is a failure under certain circumstances that Webpack rebuild will fail and throw an error that files do not exist without the hack.
PR LGTM

🏆 Enhancements
🏠 Internal
Improve typing and file organization for shared controls.
Metricdefinition insuperset-ui/core.npm link: