feat(legacy-plugin-chart-map-box): show all points in mapbox chart#960
feat(legacy-plugin-chart-map-box): show all points in mapbox chart#960villebro merged 2 commits intoapache-superset:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/23qytp6sm |
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
- Coverage 27.70% 27.69% -0.01%
==========================================
Files 401 401
Lines 8255 8257 +2
Branches 1143 1143
==========================================
Hits 2287 2287
- Misses 5831 5833 +2
Partials 137 137
Continue to review full report at Codecov.
|
| const bbox = [bounds[0][0], bounds[0][1], bounds[1][0], bounds[1][1]]; | ||
| // add this variable to widen the visible area | ||
| const offset = 0.05; | ||
| const bbox = [ | ||
| bounds[0][0] - offset, | ||
| bounds[0][1] - offset, | ||
| bounds[1][0] + offset, | ||
| bounds[1][1] + offset, | ||
| ]; |
There was a problem hiding this comment.
Applying a constant offset of 0.05 could be much or little depending on where on the zoom level. Would it make sense to make this a percentage of the width for the horizontal and height for the vertical bounds?
There was a problem hiding this comment.
done, 0.5 percentage of width and height. Can you check, please?
3 participants
Closes: apache/superset#10843
Increase area with 0.05 to include all points.
BEFORE
AFTER