fix(plugin-chart-echarts): remove columns from formData#901
fix(plugin-chart-echarts): remove columns from formData#901ktmud merged 1 commit intoapache-superset:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/nax70ln5k |
5bbfa3d to
dcf0504
Compare
dcf0504 to
47f48f2
Compare
rusackas
left a comment
There was a problem hiding this comment.
Oh man... LGTM! Let me know if you need help carrying it across to Superset.
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
=======================================
Coverage 26.66% 26.66%
=======================================
Files 405 405
Lines 8258 8258
Branches 1127 1127
=======================================
Hits 2202 2202
Misses 5927 5927
Partials 129 129
Continue to review full report at Codecov.
|
|
This change is good, but it may need to be updated soon after I deprecate |
🐛 Bug Fix
Make sure
columnsproperty isn't defined informData, as it is a reserved parameter with a specific meaning inQueryObject.