Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

chore: upgrade eslint and babel#892

Merged
ktmud merged 1 commit intoapache-superset:masterfrom
ktmud:upgrade-eslint
Jan 13, 2021
Merged

chore: upgrade eslint and babel#892
ktmud merged 1 commit intoapache-superset:masterfrom
ktmud:upgrade-eslint

Conversation

@ktmud
Copy link
Copy Markdown
Contributor

@ktmud ktmud commented Jan 10, 2021

🏠 Internal

  • Upgrade eslint, babel, and prettier related packages to the latest.
  • Fix new ESLint errors:
superset-ui/packages/superset-ui-core/test/time-format/factories/createD3TimeFormatter.test.ts
  65:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  67:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  90:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  92:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

superset-ui/packages/superset-ui-core/test/query/api/v1/makeApi.test.ts
  161:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  176:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

superset-ui/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts
  109:9   error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  121:9   error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  133:9   error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  166:9   error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  194:9   error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  195:9   error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  199:11  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  200:11  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

superset-ui/packages/superset-ui-core/test/connection/callApi/rejectAfterTimeout.test.ts
  30:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

superset-ui/packages/superset-ui-core/test/connection/callApi/parseResponse.test.ts
   76:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
   77:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
   78:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  106:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  130:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  131:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  132:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

superset-ui/packages/superset-ui-core/test/connection/callApi/callApiAndParseWithTimeout.test.ts
  101:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  102:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

/Users/jesse_yang/projects/superset-ui/packages/superset-ui-core/test/connection/callApi/callApi.test.ts
  405:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  406:9  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  443:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  444:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  445:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  459:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  460:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  461:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  487:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  488:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  540:7  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

/Users/jesse_yang/projects/superset-ui/packages/superset-ui-core/src/models/Registry.ts
   89:9  warning  Unexpected console statement  no-console
  108:9  warning  Unexpected console statement  no-console

superset-ui/packages/superset-ui-chart-controls/src/components/MetricOption.tsx
  52:5  error  Using target="_blank" without rel="noreferrer" is a security risk: see https://html.spec.whatwg.org/multipage/links.html#link-type-noopener  react/jsx-no-target-blank

@ktmud ktmud requested a review from a team as a code owner January 10, 2021 03:16
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/n0bbr54bs
✅ Preview: https://superset-ui-git-fork-ktmud-upgrade-eslint.superset.now.sh

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2021

Codecov Report

Merging #892 (950f236) into master (543e6b1) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
- Coverage   26.55%   26.54%   -0.02%     
==========================================
  Files         404      404              
  Lines        8238     8230       -8     
  Branches     1120     1119       -1     
==========================================
- Hits         2188     2185       -3     
+ Misses       5922     5917       -5     
  Partials      128      128              
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 43.52% <0.00%> (ø)
packages/superset-ui-core/src/models/Registry.ts 100.00% <ø> (ø)
...legacy-plugin-chart-calendar/src/ReactCalendar.jsx 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-chord/src/ReactChord.jsx 0.00% <0.00%> (ø)
...in-chart-force-directed/src/ReactForceDirected.jsx 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/ReactWorldMap.jsx 0.00% <0.00%> (ø)
plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 63.93% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543e6b1...950f236. Read the comment docs.

Copy link
Copy Markdown

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud merged commit 482da21 into apache-superset:master Jan 13, 2021
@ktmud ktmud deleted the upgrade-eslint branch January 13, 2021 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants