Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

feat: add resample operator to advanced analytic#1349

Merged
zhaoyongjie merged 8 commits intoapache-superset:masterfrom
zhaoyongjie:resample_operator
Sep 17, 2021
Merged

feat: add resample operator to advanced analytic#1349
zhaoyongjie merged 8 commits intoapache-superset:masterfrom
zhaoyongjie:resample_operator

Conversation

@zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Sep 6, 2021

🏆 Enhancements
Add resample operator to advanced analytic
Backend code at: apache/superset#16607

image

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner September 6, 2021 09:13
@vercel
Copy link

vercel bot commented Sep 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/5TshKxzQAtmUkP5iJ3o2zzxfWkdi
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-resampleoperator-superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1349 (cdebdb6) into master (779b942) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   30.03%   30.18%   +0.15%     
==========================================
  Files         489      492       +3     
  Lines        9856     9886      +30     
  Branches     1654     1666      +12     
==========================================
+ Hits         2960     2984      +24     
  Misses       6655     6655              
- Partials      241      247       +6     
Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 100.00% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 25.00% <ø> (ø)
...i-chart-controls/src/operators/resampleOperator.ts 100.00% <100.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 44.44% <0.00%> (-0.22%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 36.36% <0.00%> (-0.10%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 53.33% <0.00%> (-0.10%) ⬇️
plugins/plugin-chart-echarts/src/types.ts 100.00% <0.00%> (ø)
plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
plugins/plugin-chart-echarts/src/BoxPlot/types.ts 0.00% <0.00%> (ø)
...ugins/plugin-chart-echarts/src/Timeseries/types.ts 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779b942...cdebdb6. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title chore: add resample operator to advanced analytic feat: add resample operator to advanced analytic Sep 6, 2021
@zhaoyongjie zhaoyongjie requested a review from villebro September 6, 2021 10:28
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code LGTM; just one question. Testing this next.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nice work! One comment on filling operations, other than that LGTM

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - small comment here + some related ones on the follow-up PR; this looks good to go.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit f2010d3 into apache-superset:master Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants