feat: add resample operator to advanced analytic#1349
feat: add resample operator to advanced analytic#1349zhaoyongjie merged 8 commits intoapache-superset:masterfrom zhaoyongjie:resample_operator
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/5TshKxzQAtmUkP5iJ3o2zzxfWkdi |
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 30.03% 30.18% +0.15%
==========================================
Files 489 492 +3
Lines 9856 9886 +30
Branches 1654 1666 +12
==========================================
+ Hits 2960 2984 +24
Misses 6655 6655
- Partials 241 247 +6
Continue to review full report at Codecov.
|
villebro
left a comment
There was a problem hiding this comment.
Nice! Code LGTM; just one question. Testing this next.
packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx
Outdated
Show resolved
Hide resolved
packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx
Outdated
Show resolved
Hide resolved
villebro
left a comment
There was a problem hiding this comment.
This is super nice work! One comment on filling operations, other than that LGTM
packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx
Outdated
Show resolved
Hide resolved
packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx
Outdated
Show resolved
Hide resolved
villebro
left a comment
There was a problem hiding this comment.
Looks great - small comment here + some related ones on the follow-up PR; this looks good to go.
🏆 Enhancements
Add resample operator to advanced analytic
Backend code at: apache/superset#16607