Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

feat(big-number): allow fallback to last available value and fix time range for trend lines #403

Merged
kristw merged 23 commits into from
Mar 30, 2020
Merged

feat(big-number): allow fallback to last available value and fix time range for trend lines #403

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
38e6e33
feat(big-number): add option to align time range
ktmud Mar 16, 2020
3f80d84
fix(big-number): disable alignRange by default
ktmud Mar 16, 2020
14e7c48
refactor(big-number): migrate to Typescript
ktmud Mar 17, 2020
c852f2b
fix(big-number): typescript build
ktmud Mar 17, 2020
3670f55
fix(big-number): change tooltip trigger; fix storybook
ktmud Mar 17, 2020
bcf0255
fix(big-number): move @types to dependencies
ktmud Mar 17, 2020
af8512e
fix(big-number): move all files to ts
ktmud Mar 17, 2020
252e0ba
build(big-number): add @types/d3-color as dependency
ktmud Mar 17, 2020
69874ff
refactor(big-number): remove renderTooltip as prop
ktmud Mar 19, 2020
b561cf6
feat(big-number): add timeRangeUseFallback options and some refactor
ktmud Mar 21, 2020
f085a86
fix(big-number): update formatting functions
ktmud Mar 21, 2020
27e7875
fix(big-number): update copy for no data
ktmud Mar 23, 2020
e4b3d04
fix(big-number): address PR feedbacks
ktmud Mar 23, 2020
e6b0643
feat(big-number): replace timeRangeUseFallback with bigNumberFallback
ktmud Mar 25, 2020
8cf8224
fix: upgrade @types/react-bootstrap
ktmud Mar 25, 2020
116b0fb
build(big-number): move react-bootstrap to dependencies
ktmud Mar 25, 2020
3113b2d
refactor(big-number): more coherent types
ktmud Mar 25, 2020
cc2c36e
feat(big-number): use alert box for fallback values
ktmud Mar 25, 2020
61db243
build(big-number): remove react-bootstrap
ktmud Mar 28, 2020
d98f2d2
build: upgrade nimbus and fix versions
ktmud Mar 30, 2020
14da264
feat(big-number): adjust fallback warning alignment
ktmud Mar 30, 2020
7476ea4
build: use a non-fixed version for @types/shortid
ktmud Mar 30, 2020
3912f58
build: revert package versions in main
ktmud Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
],
"license": "Apache-2.0",
"devDependencies": {
"@airbnb/config-babel": "^2.1.3",
"@airbnb/config-eslint": "^2.1.3",
"@airbnb/config-jest": "^2.1.3",
"@airbnb/config-prettier": "^2.0.4",
"@airbnb/config-typescript": "^2.1.2",
"@airbnb/nimbus": "^2.1.3",
"@airbnb/config-babel": "2.2.4",

@kristw kristw Mar 30, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pin to specific version without ^?

@ktmud ktmud Mar 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was having trouble building. Couldn't figure out why. Just don't want to deal with the unpredictability. Sometimes even with the implied "not a breaking change" in a minor version upgrade, things might still break.

@kristw kristw Mar 30, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo already check in yarn.lock so if you did not modify these package version, it should be the same version that was working in master. Could you try reseting yarn.lock and package.json to master's version while keeping the changes you made to BigNumber's package.json and yarn install again?

@ktmud ktmud Mar 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, it works... I'm pretty sure I tried that yesterday... Maybe it's because I inadvertently pined @types/shortid.

I think it's probably not a bad idea to pin devDependencies as they are unlikely to cause dependency hell and the added stability is valuable. Renovate actually pin the dependencies for you once you set it up.

"@airbnb/config-eslint": "2.6.0",
"@airbnb/config-jest": "2.2.4",
"@airbnb/config-prettier": "^2.1.3",
"@airbnb/config-typescript": "2.2.4",
"@airbnb/nimbus": "2.2.5",
"@superset-ui/commit-config": "^0.0.9",
"@superset-ui/superset-ui": "^0.12.5",
"@types/enzyme": "^3.10.3",
Expand Down
3 changes: 2 additions & 1 deletion packages/superset-ui-legacy-preset-chart-big-number/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
},
"dependencies": {
"@data-ui/xy-chart": "^0.0.84",
"@types/d3-color": "^1.2.2",
"@types/shortid": "0.0.29",
Comment thread
ktmud marked this conversation as resolved.
Outdated
"d3-color": "^1.2.3",
"prop-types": "^15.6.2",
"shortid": "^2.2.14"
},
"peerDependencies": {
Expand Down
23 changes: 19 additions & 4 deletions packages/superset-ui-legacy-preset-chart-big-number/src/BigNumber/BigNumber.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
font-family: -apple-system, BlinkMacSystemFont, Segoe UI, Roboto, Oxygen, Ubuntu, Cantarell,
Open Sans, Helvetica Neue, sans-serif;
position: relative;
overflow: hidden;
display: flex;
flex-direction: column;
justify-content: center;
Expand All @@ -31,10 +30,18 @@
}

.superset-legacy-chart-big-number .text-container {
overflow: hidden;
display: flex;
flex-direction: column;
justify-content: center;
align-items: flex-start;
}

.superset-legacy-chart-big-number .text-container .alert {
font-size: 11px;
margin: -0.5em 0 0.4em;
line-height: 1;
padding: 2px 4px 3px;
border-radius: 3px;
}

.superset-legacy-chart-big-number .header-line {
Expand All @@ -46,12 +53,20 @@
.superset-legacy-chart-big-number .header-line span {
position: absolute;
bottom: 0;
left: 0;
right: 0;
}

.superset-legacy-chart-big-number .subheader-line {
line-height: 1em;
padding-bottom: 0;
font-weight: 200;
}

.superset-legacy-chart-big-number.is-fallback-value .header-line,
.superset-legacy-chart-big-number.is-fallback-value .subheader-line {
opacity: 0.5;
}

.superset-data-ui-tooltip {
z-index: 1000;
background: #000;
}
259 changes: 0 additions & 259 deletions packages/superset-ui-legacy-preset-chart-big-number/src/BigNumber/BigNumber.jsx
View file
Open in desktop

This file was deleted.

Loading