feat(big-number): format datetime according to granularity#402
feat(big-number): format datetime according to granularity#402ktmud merged 1 commit intoapache-superset:masterfrom
Conversation
|
Deploy preview for superset-ui-plugins ready! Built with commit c6e0a65 |
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=========================================
- Coverage 2.83% 2.83% -0.01%
=========================================
Files 186 186
Lines 5813 5821 +8
Branches 373 373
=========================================
Hits 165 165
- Misses 5623 5631 +8
Partials 25 25
Continue to review full report at Codecov.
|
|
Will create a follow up PR to introduce |
|
Note: Can ignore the test coverage for now. |
| subheader = '', | ||
| vizType, | ||
| } = formData; | ||
| const granularity = formData.timeGrainSqla; |
There was a problem hiding this comment.
could be part of the destructuring above
|
|
||
| const TIME_COLUMN = '__timestamp'; | ||
|
|
||
| function getTimeFormatterForGranularity(granularity) { |
There was a problem hiding this comment.
This seems useful to extract into its own file, in case we move this to @superset-ui/time-format later
|
Merge it for now. No need to publish. Will address the comments in a future PR. |
…perset#402) This adds support for "Time Grain" in Superset for Big Number with Trendline chart.
2 participants
🏆 Enhancements
This adds support for "Time Grain" in Superset for Big Number with Trendline chart.
It will now render date format in tooltip according to the time granularity.
Before
When "Time Grain" is set to "Quarter":
After
When "Time Grain" is set to "Quarter":