Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Fix NPE around unschedulable pod specs#79

Merged
mccheah merged 1 commit intok8s-support-alternate-incrementalfrom
fix/npe-submit
Feb 2, 2017
Merged

Fix NPE around unschedulable pod specs#79
mccheah merged 1 commit intok8s-support-alternate-incrementalfrom
fix/npe-submit

Conversation

@ash211
Copy link
Copy Markdown

@ash211 ash211 commented Feb 2, 2017

Fixes #77

This is another instance where our minikube ete tests aren't sufficient to catch problems running on live clusters, like the kubeadm-created one I've been testing with.

@ash211
Copy link
Copy Markdown
Author

ash211 commented Feb 2, 2017

@foxish we have to check nullability here (good practice anyway) because apparently my kubeadm-created cluster doesn't set Unschedulable on some/all of the nodes.

@mccheah good to merge this hotfix when this build is green?

@foxish
Copy link
Copy Markdown
Member

foxish commented Feb 2, 2017

That makes sense, and is true of other clusters as well. The absence of unschedulable is equivalent to it being marked false.

@foxish
Copy link
Copy Markdown
Member

foxish commented Feb 2, 2017

LGTM

@mccheah
Copy link
Copy Markdown

mccheah commented Feb 2, 2017

Looks fine.

@mccheah mccheah merged commit 43c918c into k8s-support-alternate-incremental Feb 2, 2017
@mccheah mccheah deleted the fix/npe-submit branch February 2, 2017 23:13
ash211 added a commit that referenced this pull request Feb 8, 2017
ash211 added a commit that referenced this pull request Mar 8, 2017
foxish pushed a commit that referenced this pull request Jul 24, 2017
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
…8s#79)

Commonly encountered because of dropped responses from the driver back to an
executor authorizing a commit.
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants