Added service name as prefix to executor pods#14
Added service name as prefix to executor pods#14ash211 merged 2 commits intok8s-support-alternate-incrementalfrom
Conversation
… apart from kubectl output
| val executorKubernetesId = UUID.randomUUID().toString.replaceAll("-", "") | ||
| val executorId = EXECUTOR_ID_COUNTER.incrementAndGet().toString | ||
| val name = s"exec$executorKubernetesId" | ||
| val name = s"$kubernetesDriverServiceName-exec$executorKubernetesId" |
There was a problem hiding this comment.
I ran into name length constraints before while trying to figure out the name. But if this works then I'm fine with this change.
There was a problem hiding this comment.
That is a good point. I'll check the constraints we impose and see if some truncation is needed. IIRC, it's the service names that typically complain about length because they're involved in DNS domain creation.
| val executorKubernetesId = UUID.randomUUID().toString.replaceAll("-", "") | ||
| val executorId = EXECUTOR_ID_COUNTER.incrementAndGet().toString | ||
| val name = s"exec$executorKubernetesId" | ||
| val name = s"$kubernetesDriverServiceName-exec$executorKubernetesId" |
There was a problem hiding this comment.
is there a common convention in k8s for pod names? kebab-case? I might suggest we make this slightly more verbose:
s"$kubernetesDriverServiceName-executor-$executorKubernetesId
There was a problem hiding this comment.
I believe the common convention is the kebab-case.
+1 on making the pod name verbose.
|
@foxish are you good with modifying that podname to have the fuller Any news on the pod name length constraints? |
|
253 characters for the pod name and 63 characters for service name, which means we should be well within the limits. Will make the change to kebab-case shortly. |
* Added service name as prefix to executor pods to be able to tell them apart from kubectl output * Addressed comments
* Added service name as prefix to executor pods to be able to tell them apart from kubectl output * Addressed comments
* Added service name as prefix to executor pods to be able to tell them apart from kubectl output * Addressed comments
* Added service name as prefix to executor pods to be able to tell them apart from kubectl output * Addressed comments
* Added service name as prefix to executor pods to be able to tell them apart from kubectl output * Addressed comments
4 participants
Minor change to identify by name, the executor pods created by a particular driver.
/cc @mccheah @ash211