-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import connect
into query, connect docstring improvements
#44
Conversation
71d1cb4
to
17deaf9
Compare
connect
into query, docstring improvementsconnect
into query, connect docstring improvements
1792b7c
to
fd6e0ca
Compare
I have no earthly idea why 441790f fixes the tests, would love for someone else to have a look and tell me why. |
There may be some conflicts between the |
@danielcompton, on line 27 there's (def close ...) ; <= for connections but then on line 34 there's (defn close ...) ; <= for cursors So when you (:require [rehtinkdb.query :as r])
;; ...
(r/close ...) it refers to the cursor-closing function. That's my guess anyway. |
Confirmed: (in-ns 'rethinkdb.query)
(doc close)
|
Since |
441790f
to
dfb57d9
Compare
dfb57d9
to
dabbbb3
Compare
After fixing #50, there's no need to add a query/close function here. I've removed the commits and rebased against master. |
Import `connect` into query, connect docstring improvements
It is often a pain to have to import the
rethinkdb.core
namespace just to make a connection. This PR imports the connect function into therethinkdb.query
ns which is the most common ns for API consumers to be using.I wasn't keen on using something like Potemkin for a single function, sing out if you've got alternative approaches or have an issue with this, otherwise I'll merge this in a few days.