Repository navigation
Conversation
The ST projector is loaded from the Dense folders and held by DispatchPooler sub-poolers outside the module tree, so sleep mode level 2 dropped it: embeddinggemma-300m embeddings differed by up to 0.153 after wake. Register the projector under DispatchPooler and its weights as constant buffers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Sleep mode level 2 dropped the Sentence-Transformers projector, so embeddings changed after wake. Stacked on #95 (the registration helpers and the CI allowlist); review only the top commit.
Claims
sleep(2)/wake_up()/reload_weights()for models with an ST projector (e.g. embeddinggemma-300m).\.head\.projector\.fromKNOWN_UNREGISTERED.Validation
GB200, image
nightly-dev-arm64-cu130-ac9126e58aa7overlaid with the framework PR plus this change.test_initializationon the 29 architectures in the allowlistDetails
The projector is built from the ST
Densefolders and held byDispatchPoolersub-poolers, outside the module tree, so its weights were neither parameters nor buffers.DispatchPoolernow holds the projectors in aModuleList(sub-poolers can hold modules owned elsewhere, so only the projectors join), and the projector weights become constant buffers so strict checkpoint loading does not expect them.AI assistance. Written with Claude Code; audited by Claude Fable 5.1, Codex (gpt-6-astra) and Kimi K3 as part of the combined change. The submitter reviewed every changed line and ran the checks above.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code