fixed what-if grade bug related to multiple semesters #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Changed
Fixed a bug where what-if grades wouldn't enable and point total would display as because there were missing assignments from second semester, and the code that looks through the class to find assignments was checking period[0], whereas these assignments were in period[1], so I modified grades.js so it checks the assignment lists for all periods.
Screenshots of Changes
schoology.plus.grade.bug.vid.mp4
The three missing assignments you see are the ones that caused the error.
Issues Closed By This Pull Request
Related to #228 but I'm not sure if it fixes that, because I didn't see multiple semesters in the screenshots for context in that issue.