Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed what-if grade bug related to multiple semesters #250

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

EricPedley
Copy link
Contributor

What I Changed

Please enter a thorough and detailed description of everything you changed in this pull request.

Fixed a bug where what-if grades wouldn't enable and point total would display as because there were missing assignments from second semester, and the code that looks through the class to find assignments was checking period[0], whereas these assignments were in period[1], so I modified grades.js so it checks the assignment lists for all periods.

Screenshots of Changes

Please include screenshots of each change you made either in this section or in the What I Changed section above.
Screenshots are required as we need to have a visual indication of what you did.

schoology.plus.grade.bug.vid.mp4

The three missing assignments you see are the ones that caused the error.

Issues Closed By This Pull Request

Please mention all issues this pull request addresses or closes.
If the issue is a GitHub issue, please reference it using the #9999 syntax.
If the issue is a Bug Bot issue, please reference it using it's shortcode, like DARK-9999 or BUG-9999.
Not all changes will necessarily have an issue ticket associated with them, but if they do you must mention it here

Related to #228 but I'm not sure if it fixes that, because I didn't see multiple semesters in the screenshots for context in that issue.

@aopell
Copy link
Owner

aopell commented Feb 1, 2021

Hi, thanks for making a pull request! I haven't really had the chance to look it over too thoroughly yet, but we're definitely aware this bug exists. There's a chance the fix might be a little more complex than this, but again I haven't looked too thoroughly.

I'll take a closer look soon, but once again, thanks!

Copy link
Owner

@aopell aopell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes! They look good! Sorry for the delay

@aopell aopell merged commit 02f693c into aopell:develop Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants