Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

add PROGRESS.md and connect to k8s endpoint to check namespace exists#1

Merged
gregcusack merged 2 commits intoanza-xyz:mainfrom
gregcusack:main
Mar 27, 2024
Merged

add PROGRESS.md and connect to k8s endpoint to check namespace exists#1
gregcusack merged 2 commits intoanza-xyz:mainfrom
gregcusack:main

Conversation

@gregcusack
Copy link
Copy Markdown
Contributor

Summary of Changes

  1. Add in PROGRESS.md to track progress of building Validator Lab
  2. Add scripts for rust formatting
  3. Add ability to talk to kubernetes endpoint and check if a namespace exists

1st PR in a series of PRs that will build out Validator Lab. The Mongon testing framework for deploying validator clusters on Kubernetes

@yihau yihau requested review from yihau and removed request for anza-team March 27, 2024 15:22
Copy link
Copy Markdown
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

nit: noticed that you have some files copied from monorepo. I have some ideas about them:

  1. do we need the fmt as a part of CI?
  2. do we want to enable nightly features like group_imports = One or imports_granularity = One?

if 1 is negative, I think we can remove all these files in this PR

  • ./cargo
  • ./ci/*
  • ./scripts/*

if we want 1) to happen, I can get it run in Github Actions later!

about 2), if we want those nightly features, we will need to add rustfmt.toml or .rustfmt.toml like monorepo. if we don't need them, I think we can remove some nightly related code.

we can clean up later or in this PR. both work!

@gregcusack
Copy link
Copy Markdown
Contributor Author

ya i guess I am not sure the best way to go about the fmt. I like the idea of having to have a specific code format as in the monorepo. Definitely want like the sanity checks and stuff as in the monorepo. Is that something I need to setup?

I do want imports_granularity = One and group_imports = One. I'll push rustfmt.toml

@gregcusack gregcusack requested a review from yihau March 27, 2024 16:23
Copy link
Copy Markdown
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking to have CI in Github Actions due to this one will be a small project (maybe 🤔 ). shouldn't take too much time for clippy and formatting.
I can setup them later. you can just list the steps you wanna to have!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants