Upgrade to wincode 0.4.1#563
Conversation
8fe7599 to
6606ee9
Compare
|
lgtm from tx-metadata. @febo I think this will conflict with #538. Waiting for @joncinque to give approval before I press appove, only question I have is on the other cargo updates - do we usually update in a group like this or separately (do we care?) |
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! Just so I'm sure I understand though, this will be a breaking change across all types that implement the wincode traits, correct?
It fails the
Yes, correct |
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! The rebase didn't look too bad thankfully
wincode
0.3.0:Configtype parameter toSchemaReadandSchemaWriteSchemaReadandSchemaWriteasunsafetraitswincode
0.4.0:SchemaReadandSchemaWriteon types with with generic type parametersSchemaReadandSchemaWritetrait definitions to useimpl Readerandimpl Writerrather than&mut impl Readerand&mut impl Writer, respectively