Skip to content

Upgrade to wincode 0.4.1#563

Merged
cpubot merged 1 commit into
anza-xyz:masterfrom
cpubot:wincode-0.4.0
Feb 9, 2026
Merged

Upgrade to wincode 0.4.1#563
cpubot merged 1 commit into
anza-xyz:masterfrom
cpubot:wincode-0.4.0

Conversation

@cpubot
Copy link
Copy Markdown
Contributor

@cpubot cpubot commented Feb 7, 2026

wincode 0.3.0:

  • adds a new Config type parameter to SchemaRead and SchemaWrite
  • marks SchemaRead and SchemaWrite as unsafe traits
  • provides built-in support for customizable length encodings

wincode 0.4.0:

  • enables deriving SchemaRead and SchemaWrite on types with with generic type parameters
  • adjusts SchemaRead and SchemaWrite trait definitions to use impl Reader and impl Writer rather than &mut impl Reader and &mut impl Writer, respectively

@cpubot cpubot requested a review from a team as a code owner February 7, 2026 21:56
@cpubot cpubot force-pushed the wincode-0.4.0 branch 3 times, most recently from 8fe7599 to 6606ee9 Compare February 8, 2026 01:14
@cpubot cpubot changed the title Upgrade to wincode 0.4.0 Upgrade to wincode 0.4.1 Feb 8, 2026
@cpubot cpubot requested review from joncinque and kskalski February 8, 2026 23:13
Copy link
Copy Markdown
Contributor

@kskalski kskalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apfitzge
Copy link
Copy Markdown
Contributor

apfitzge commented Feb 9, 2026

lgtm from tx-metadata. @febo I think this will conflict with #538.

Waiting for @joncinque to give approval before I press appove, only question I have is on the other cargo updates - do we usually update in a group like this or separately (do we care?)

@febo
Copy link
Copy Markdown
Contributor

febo commented Feb 9, 2026

lgtm from tx-metadata. @febo I think this will conflict with #538.

Yes, indeed.

joncinque
joncinque previously approved these changes Feb 9, 2026
Copy link
Copy Markdown
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just so I'm sure I understand though, this will be a breaking change across all types that implement the wincode traits, correct?

@cpubot
Copy link
Copy Markdown
Contributor Author

cpubot commented Feb 9, 2026

only question I have is on the other cargo updates - do we usually update in a group like this or separately (do we care?)

It fails the Check minimal-versions CI step otherwise, so figured it made sense to do it here.

this will be a breaking change across all types that implement the wincode traits, correct?

Yes, correct

@cpubot cpubot enabled auto-merge (squash) February 9, 2026 19:57
@cpubot
Copy link
Copy Markdown
Contributor Author

cpubot commented Feb 9, 2026

Rebased with @febo's #538

Copy link
Copy Markdown
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The rebase didn't look too bad thankfully

Copy link
Copy Markdown
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cpubot cpubot merged commit 80b834a into anza-xyz:master Feb 9, 2026
30 checks passed
@cpubot cpubot deleted the wincode-0.4.0 branch February 9, 2026 22:49
@febo febo mentioned this pull request Feb 11, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants