instruction-view: Add new crate by febo · Pull Request #401 · anza-xyz/solana-sdk

febo · 2025-10-23T10:47:35Z

Problem

Currently pinocchio provides a CU efficient way to perform cross-program invocation by using zero-copy structs to represent instruction-related data, which can be used with sol_invoke_signed_c syscall.

Solution

Add a new solana-instruction-view crate moving the types from pinocchio – the main type of this crate is the InstructionView.

The crate also includes a feature for cross-program invocations ("cpi") syscalls.

febo · 2025-11-14T18:26:20Z

Waiting on #442 to rebase.

* [wip]: Address review comments * [wip]: Fix pointer reference * [wip]: Add logger buffer size tests * Remove unused * More logger tests * Rename program to cpi * Remove dynamic allocation * Fixed signed tests * Fix review comments * Fix unsigned test case * Add is_owner_by helper

* Add resize * Deprecate realloc

Ignore zero_init parameter

* Use macro rules * Update directory structure

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

* [wip]: Add new scripts * [wip]: Use matric strategy * [wip]: Fix members parsing * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Review comments * Fix lint comments * Expand crate comment * Ignore crate comment tests * Add missing docs * More missing docs * Add missing release component * Pin cargo-release version * Fix merge * Review comments

* use `seeds` macro over `signer` macro * fix doc to pass doc test * deprecate macro

* [wip]: Address review comments * [wip]: Fix pointer reference * [wip]: Add logger buffer size tests * Remove unused * More logger tests * Rename program to cpi * Remove dynamic allocation * Fixed signed tests * Fix review comments * Fix unsigned test case * Add is_owner_by helper

* add memo program * use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS * nit * add account info borrowing check * update docstring and comments * use &str over &[u8] * check num_accounts * avoid unnecessary codegen * update doc to use &str over &[u8] * fix doc * seperate lifetime

* Improve fallback and docs * Add borrow state check * Add inline * Review comments * Revert doc link merge change

* Fix review comments * Revert offset increment change * Improve invoke performance * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak iteration * More tweaks * Limit the length of the slice * Uncomment code * Validate account length * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Fix accounts length test * Revert change * Add constant length check * Review comments * Fix error variant

* Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Add spellcheck step * Tweak action * Fix typos * More fixes * Yet more fixes * Fixes * Add j1 option * More and more fixes * Add missing acronym * Fix merge * Fix spelling * Fix spelling

* Add comments on constants * Improve offset comments * Add bitmask to dictionary * Renamed to field_at_offset

…-xyz#228) * Add debug/copy derives and enable missing debug/copy lint * Update sdk/pinocchio/src/sysvars/rent.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/entrypoint/mod.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/instruction.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/clock.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/clock.rs * Fix syntax error in Instructions struct derive macro --------- Co-authored-by: Fernando Otero <febo@anza.xyz>

febo · 2025-11-19T14:22:00Z

Waiting on #442 to rebase.

@joncinque Rebase done.

joncinque

Looks great overall! Mostly small comments and nits

joncinque

Looks good to me! It's up to you if you want to do the alloc work here though, whichever you prefer

febo · 2025-11-20T13:13:15Z

Looks good to me! It's up to you if you want to do the alloc work here though, whichever you prefer

I had a go at refactoring the invoke to support the actual maximum of CPI accounts (commit 491515b). The downside is that it requires a small bump on the minimum Rust version. We could implement with a Vec, but using the Box seems cleaner. If we don't want to bump the MSRV, then I can change the implementation.

joncinque

Just a few last nits, looks really close!

febo · 2025-11-21T10:52:08Z

          cargo-cache-key: cargo-minimum-check
          cargo-cache-fallback-key: cargo-minimum

+      - name: Install additional toolchains


We could add a cache to this step, but it does not seem to take very long since one of the toolchains will usually be installed already.

This looks fine to me! It only takes 8 seconds, and the whole check is less than a minute

febo · 2025-11-21T10:53:26Z

@@ -0,0 +1,25 @@
+#!/usr/bin/env bash


Not sure if we need a separate script for this – we could just add its contents to the github workflow directly.

It can't hurt, looks good!

joncinque

Beautiful!

joncinque · 2025-11-21T13:07:18Z

          cargo-cache-key: cargo-minimum-check
          cargo-cache-fallback-key: cargo-minimum

+      - name: Install additional toolchains


This looks fine to me! It only takes 8 seconds, and the whole check is less than a minute

joncinque · 2025-11-21T13:07:29Z

@@ -0,0 +1,25 @@
+#!/usr/bin/env bash


It can't hurt, looks good!

febo commented Oct 23, 2025

View reviewed changes

Comment thread instruction-view/src/lib.rs Outdated

febo force-pushed the solana-instruction-view branch from 902e59c to 104f4cc Compare October 23, 2025 11:17

febo marked this pull request as ready for review October 23, 2025 12:23

febo requested a review from joncinque October 23, 2025 12:23

febo marked this pull request as draft November 14, 2025 18:25

febo and others added 24 commits November 19, 2025 14:16

Add derive address helpers

374b269

Update lock file

5038382

Fix doc links

ae5c782

Add missing dependency

c1d619f

Deprecate AccountInfo::realloc (anza-xyz#174)

a755026

* Add resize * Deprecate realloc

Ignore zero_init parameter (anza-xyz#203)

66a2af6

Ignore zero_init parameter

Remove unused

acd9c52

Refactor directory structure (anza-xyz#18)

d59ce99

* Use macro rules * Update directory structure

Add from_slice helper (anza-xyz#23)

ead8aa5

Fix signer from helpers

6be06b0

Add signer macro

46c0ddf

Fix doctest

776cf4e

Add checked_create_program_address helper (anza-xyz#30)

75c16ef

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

add seeds macro (anza-xyz#73)

db2d727

* use `seeds` macro over `signer` macro * fix doc to pass doc test * deprecate macro

Account borrow state check (anza-xyz#147)

dc55079

* Improve fallback and docs * Add borrow state check * Add inline * Review comments * Revert doc link merge change

Add const qualifier (anza-xyz#159)

adee2cf

Clarify the use of constant values (anza-xyz#200)

80b035a

* Add comments on constants * Improve offset comments * Add bitmask to dictionary * Renamed to field_at_offset

febo added 4 commits November 19, 2025 14:17

Add target_arch bpf

73b1809

Fix rebase

c8c57ce

Fix lint

7badd2b

Simplify definition

fec6cf7

febo force-pushed the solana-instruction-view branch from 3a5bc83 to fec6cf7 Compare November 19, 2025 14:21

febo marked this pull request as ready for review November 19, 2025 14:21

Fix doc feature

219c2f6

febo commented Nov 19, 2025

View reviewed changes

Comment thread instruction-view/src/cpi.rs Outdated

joncinque reviewed Nov 19, 2025

View reviewed changes

Address review comments

47781b0

febo commented Nov 20, 2025

View reviewed changes

Comment thread instruction-view/src/lib.rs

joncinque previously approved these changes Nov 20, 2025

View reviewed changes

febo dismissed joncinque’s stale review via 111404c November 20, 2025 13:06

Refactored slice support

491515b

febo force-pushed the solana-instruction-view branch from 111404c to 491515b Compare November 20, 2025 13:11

febo requested a review from joncinque November 20, 2025 13:14

febo added 2 commits November 20, 2025 16:06

Improve code reuse

c38c28f

Update msrv check

885b1bf

joncinque reviewed Nov 20, 2025

View reviewed changes

Comment thread scripts/check-msrv.sh Outdated

Comment thread instruction-view/src/cpi.rs Outdated

Comment thread instruction-view/src/cpi.rs Outdated

Comment thread instruction-view/src/cpi.rs Outdated

Comment thread instruction-view/src/cpi.rs

febo added 4 commits November 21, 2025 10:35

More review comments

18cd540

Use crate rust-version

f432db3

Double quotes

fae99c3

Fix docs

99315b1

febo commented Nov 21, 2025

View reviewed changes

febo requested a review from joncinque November 21, 2025 10:53

joncinque approved these changes Nov 21, 2025

View reviewed changes

febo merged commit 6b7745f into anza-xyz:master Nov 21, 2025
24 checks passed

Conversation

febo commented Oct 23, 2025

Problem

Solution

Uh oh!

Uh oh!

febo commented Nov 14, 2025

Uh oh!

febo commented Nov 19, 2025

Uh oh!

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

febo commented Nov 20, 2025

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

febo Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

febo Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

joncinque Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants