feat: VoteStateV4 goodies#331
Conversation
|
This is a lossy conversion. Can you explain why this would be needed? I don't think we want this |
How would we handle the above function for |
ksn6
changed the title
VoteStateV4 to VoteStateV3VoteStateV4 goodies
| pub authorized_voter: Pubkey, | ||
| pub authorized_withdrawer: Pubkey, | ||
| pub commission: u8, | ||
|
|
There was a problem hiding this comment.
@jstarry @buffalojoec - should we add in fields for the inflation bps and block rewards bps commissions?
|
|
||
| impl VoteStateV4 { | ||
| pub fn new(vote_init: &VoteInit, clock: &Clock) -> Self { | ||
| let inflation_rewards_commission_bps = (vote_init.commission as u16) |
There was a problem hiding this comment.
@jstarry @buffalojoec - leaving this as a placeholder, though we probably don't want to do this. My guess is that we want VoteInit to have both commission bps fields.
| } | ||
|
|
||
| pub fn commission(&self) -> Result<u8, InstructionError> { | ||
| let commission_bps = self |
|
We can close this in favor of anza-xyz/agave#8108 / anza-xyz/agave#8120 |
2 participants
No description provided.