all!: Remove deprecated functions and structs by joncinque · Pull Request #229 · anza-xyz/solana-sdk

joncinque · 2025-07-15T20:59:31Z

Problem

There are a lot of deprecated functions and structs all over the SDK that can be removed now that we're making breaking changes.

Summary of changes

Remove it all!

#### Problem There are a lot of deprecated functions and structs all over the SDK that can be removed now that we're making breaking changes. #### Summary of changes Remove it all!

github-actions · 2025-07-15T20:59:49Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

github-actions · 2025-07-15T21:07:07Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

febo

Looks great – only have a question about the changes on AccountInfo.

apfitzge · 2025-07-17T19:01:00Z

    }

    fn create_sample_transaction() -> Transaction {
-        let keypair = Keypair::from_bytes(&[


weird, wonder why this wasn't complaining about us using a deprecated fn previously.

line 1136 has #![allow(deprecated)] for the whole testing module -- i'll fix that up in a follow-up

apfitzge

looks good on tx-metadata changes

* Remove deprecated functions and structs #### Problem There are a lot of deprecated functions and structs all over the SDK that can be removed now that we're making breaking changes. #### Summary of changes Remove it all! * Fixup CI errors

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

@febo

* Add derive address helpers * Update lock file * Fix doc links * Add missing dependency * Refactor directory structure (#18) * Use macro rules * Update directory structure * Add account info and pubkey helpers (#21) * Rename unchecked methods (#22) * Add map and filter_map to Ref and RefMut (#27) * Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions * Add bit flag for original data length (#28) * Add bit flag * Remove declarative macro * Add `checked_create_program_address` helper (#30) * Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params * A close macro implementation for AccountInfo (#42) * Added close and based_close * added docs comments + wrapped up and tested both function * cargo clippy and fmt * added the new close and changed the name for * fixed and tested after comments * Fixed Realloc Macro (#45) * Fixed compiler bitching about realloc * Added a better alterantive to the black_box * Fixed latest comments * deleted some line after the refactor * Update comments * Fix last u64 owner index on close (#55) * Fix clippy warnings (#59) * Improve close unchecked * sdk: Improve comments (#64) * [wip]: Add new scripts * [wip]: Use matric strategy * [wip]: Fix members parsing * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Review comments * Fix lint comments * Expand crate comment * Ignore crate comment tests * Add missing docs * More missing docs * Add missing release component * Pin cargo-release version * Fix merge * Review comments * sdk: Lightweight borrow check (#65) * [wip]: Add new scripts * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Add check methods * Use check variant on close * Fix merge * Address review comments (#78) * [wip]: Address review comments * [wip]: Fix pointer reference * [wip]: Add logger buffer size tests * Remove unused * More logger tests * Rename program to cpi * Remove dynamic allocation * Fixed signed tests * Fix review comments * Fix unsigned test case * Add is_owner_by helper * Account borrow state check (#147) * Improve fallback and docs * Add borrow state check * Add inline * Review comments * Revert doc link merge change * Update doc comments on close account (#173) * Update doc comments * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Jon C <me@jonc.dev> * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Jon C <me@jonc.dev> --------- Co-authored-by: Jon C <me@jonc.dev> * Remove *const cast (#170) * Add cargo miri test to CI (#178) * Add miri step * Fix miri issues * Install miri component * Deprecate AccountInfo::realloc (#174) * Add resize * Deprecate realloc * Simplify program entrypoint (#166) * Fix review comments * Revert offset increment change * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Simplify accounts deserialization * Invert borrow state logic * Use expr instead * Add missing import * Address review comments * Revert unnecessary repr * Fix rebase * Tweak docs * Fix doc reference * Fix miri errors * More review comments * Simplify realloc logic (#175) * Simplify realloc logic * Address review comments * Fix `assign` unsoundness (#180) * Fix assign unsoundness * Remove unsafe * ci: Add spellcheck step (#164) * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Add spellcheck step * Tweak action * Fix typos * More fixes * Yet more fixes * Fixes * Add j1 option * More and more fixes * Add missing acronym * Fix merge * Fix spelling * Fix spelling * Clarify the use of constant values (#200) * Add comments on constants * Improve offset comments * Add bitmask to dictionary * Renamed to field_at_offset * Ignore `zero_init` parameter (#203) Ignore zero_init parameter * Add resize_unchecked method to account info (#230) * add resize_unchecked method to account info * Apply suggestion from @febo Co-authored-by: Fernando Otero <febo@anza.xyz> * Apply suggestion from @febo Co-authored-by: Fernando Otero <febo@anza.xyz> * Apply suggestion from @febo Co-authored-by: Fernando Otero <febo@anza.xyz> --------- Co-authored-by: Fernando Otero <febo@anza.xyz> * Feat: Add debug/copy derives and enable missing debug/copy lint (#228) * Add debug/copy derives and enable missing debug/copy lint * Update sdk/pinocchio/src/sysvars/rent.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/entrypoint/mod.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/instruction.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/clock.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update sdk/pinocchio/src/sysvars/clock.rs * Fix syntax error in Instructions struct derive macro --------- Co-authored-by: Fernando Otero <febo@anza.xyz> * Feat: make AccountInfo::data_ptr public (#232) * make data_ptr public * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * add some tests for data ptr * Fix spelling --------- Co-authored-by: Fernando Otero <febo@anza.xyz> * Feat: Add try_maps on AccountInfo Ref/RefMut (#229) * Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref * pinocchio: Move `NON_DUP_MARKER` const (#245) Move NON_DUP_MARKER const * chore: fix typo in comment (#240) Signed-off-by: vetclippy <vetclippy@icloud.com> * pinocchio: Add `pubkey_eq` helper (#248) * Add pubkey_eq helper * Fix typo * Update pubkey comparison * Add proptest * Add unlikely * Replace proptest * pinocchio: Add `AccountInfo` invariant details (#254) Add invariant details * Add account view * Improve account borrows * Add constructor * Add account_ptr method * Add copy feature * Add docs configuration * Rename to address * Use clone * Remove unused * Add missing doc_auto_cfg * Fix lints * Add no_std check * Rename account type --------- Signed-off-by: vetclippy <vetclippy@icloud.com> Co-authored-by: Jean Marchand (Exotic Markets) <jeanno11@orange.fr> Co-authored-by: Leonardo Donatacci <125566964+L0STE@users.noreply.github.com> Co-authored-by: Dimitris Apostolou <dimitris.apostolou@icloud.com> Co-authored-by: Jon C <me@jonc.dev> Co-authored-by: Sammy Harris <41593264+stegaBOB@users.noreply.github.com> Co-authored-by: vetclippy <vetclippy@icloud.com>

Remove deprecated functions and structs

28df64f

#### Problem There are a lot of deprecated functions and structs all over the SDK that can be removed now that we're making breaking changes. #### Summary of changes Remove it all!

joncinque requested a review from febo July 15, 2025 20:59

joncinque requested a review from a team as a code owner July 15, 2025 20:59

joncinque added the breaking PR contains breaking changes label Jul 15, 2025

Fixup CI errors

12e696c

febo reviewed Jul 15, 2025

View reviewed changes

Comment thread account-info/src/lib.rs

febo reviewed Jul 15, 2025

View reviewed changes

Lichtso approved these changes Jul 16, 2025

View reviewed changes

febo approved these changes Jul 17, 2025

View reviewed changes

apfitzge reviewed Jul 17, 2025

View reviewed changes

apfitzge approved these changes Jul 17, 2025

View reviewed changes

joncinque merged commit 82909e6 into anza-xyz:master Jul 17, 2025
26 checks passed

joncinque deleted the rm-deprecated branch July 17, 2025 20:14

joncinque mentioned this pull request Jul 25, 2025

v3: Tracking issue for upcoming breaking changes #84

Closed

febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 21, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

882edb1

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 22, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

c0bc011

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 22, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

88aa4d1

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 2, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

f0fb400

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 2, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

7d54afb

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 16, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

efec777

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 17, 2025

Feat: Add try_maps on AccountInfo Ref/RefMut (anza-xyz#229)

109ce33

* Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all!: Remove deprecated functions and structs#229

all!: Remove deprecated functions and structs#229
joncinque merged 2 commits intoanza-xyz:masterfrom
joncinque:rm-deprecated

joncinque commented Jul 15, 2025

Uh oh!

github-actions Bot commented Jul 15, 2025

Uh oh!

github-actions Bot commented Jul 15, 2025

Uh oh!

Uh oh!

febo left a comment

Uh oh!

apfitzge Jul 17, 2025

Uh oh!

joncinque Jul 17, 2025

Uh oh!

apfitzge left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joncinque commented Jul 15, 2025

Problem

Summary of changes

Uh oh!

github-actions Bot commented Jul 15, 2025

Uh oh!

github-actions Bot commented Jul 15, 2025

Uh oh!

Uh oh!

febo left a comment

Choose a reason for hiding this comment

Uh oh!

apfitzge Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

apfitzge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants