Increase quic heartbeat interval to 45 second to reduce overhead#201
Merged
lijunwangs merged 1 commit intomasterfrom Jun 20, 2025
Merged
Increase quic heartbeat interval to 45 second to reduce overhead#201lijunwangs merged 1 commit intomasterfrom
lijunwangs merged 1 commit intomasterfrom
Conversation
Contributor
|
Generally this is a good idea, just for the record, in which version did the increased value for the timeouts on the streamer side land? |
Contributor
Author
it is released in solana-quic-definitions 2.3.0. -- which I will update our validator to take in another PR in agave repo. After this PR lands we will release solana-quic-definitions with another version 2.3.1 or whatever number. |
alessandrod
approved these changes
Jun 20, 2025
Contributor
|
why 45s and not 60s or another number? |
Contributor
Author
60s could cause timeout due to latency in scheduling and on the wire. 45 s is a heuristic value to ensure with 60 second we see at least 1 timeout and no more than 2. |
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the change to increase QUIC connection timeout has been released. Now we can afford to reduce the frequency to send QUIC keep-alive messages.
The interval is changed from 1 s to 45 seconds
This to follow up on #29.