Conversation
febo
force-pushed
the
febo/remove-log
branch
2 times, most recently
from
76f57e7 to
fa2bc23
Compare
febo
force-pushed
the
febo/remove-log
branch
from
fa2bc23 to
54947c3
Compare
febo
force-pushed
the
febo/remove-log
branch
from
8a438a4 to
3363631
Compare
febo
force-pushed
the
febo/use-alloc
branch
2 times, most recently
from
ae9bbcc to
40d4c67
Compare
febo
force-pushed
the
febo/remove-log
branch
from
3363631 to
238851b
Compare
febo
force-pushed
the
febo/remove-log
branch
from
854599f to
69cd82a
Compare
febo
force-pushed
the
febo/remove-log
branch
from
69cd82a to
0755d24
Compare
febo
force-pushed
the
febo/remove-log
branch
from
0755d24 to
2dabab6
Compare
febo
dismissed stale reviews from joncinque and rustopian
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Now that
pinocchio-logmoved to the SDK undersolana-program-log(anza-xyz/solana-sdk#356), there is no need to keep the duplicated code.Solution
Remove the "log" directory under "sdk". Since there is now a single directory under the "sdk", this PR also moves the content of "sdk/pinocchio" to "sdk".