Fix duplicated account parsing#209
Merged
Merged
Conversation
febo
commented
Jul 19, 2025
illia-bobyr
previously approved these changes
Jul 19, 2025
joncinque
previously approved these changes
Jul 21, 2025
Collaborator
joncinque
left a comment
There was a problem hiding this comment.
Ah too bad this snuck in, but looks good to me! I feel silly because I almost asked for a test with duplicates in the previous PR.
Collaborator
Author
I feel the same. There was not a good reason not to include one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #176 refactored the entrypoint and inlined the processing of accounts, but the parsing of duplicated accounts is wrongly storing the address to an
AccountInfoinstead of anAccount.Solution
Dereference the
AccountInfoto store the address of itsAccount. The PR also includes a test for duplicated account parsing.As a side-effect of the fix, CU consumption improved:
cc: @cavemanloverboy
Fixes #208