Account borrow state check#147
Merged
Merged
Conversation
joncinque
reviewed
Apr 30, 2025
Collaborator
joncinque
left a comment
There was a problem hiding this comment.
This looks really great! Just a couple of nits
joncinque
approved these changes
May 1, 2025
publicqi
added a commit
to publicqi/pinocchio
that referenced
this pull request
May 5, 2025
This reverts commit 59aa6cb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The account borrow check done on CPIs is slightly more expensive than it needs to be, since it also checks whether another borrow can be made or not.
Solution
Create a
BorrowStateenum to represent different borrow masks. This allows to perform checks on the account borrow state. This will enable CPI helpers that already set the accounts in the correct order to use*_uncheckedvariants, but still perform borrow checks.It also makes 2 other improvements related to CPIs:
invoke_signed_uncheckedMaybeUnitfor the pubkey in theget_return_data