Improve allocators set up#140
Closed
febo wants to merge 4 commits into
Closed
Conversation
012d4ae to
fada003
Compare
joncinque
reviewed
Apr 22, 2025
Collaborator
joncinque
left a comment
There was a problem hiding this comment.
Looks great! I'm a big fan of the lengthy and clear comments.
Just a tiny nit
joncinque
approved these changes
Apr 23, 2025
Collaborator
Author
|
The refactoring for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the "fallback" panic handler and allocator set up creates different problems when using
cargo testorcargo test-sbf. This happens since tests in general depend on thestdand therefore create a conflict when the fallback tries to set up a panic handler or global allocator.Solution
This PR improves the set up of the fallbacks by simply linking the
stdlibrary instead of trying to set them up, avoiding conflicts if another library links thestd. Note that thestdis only linked in targets different than"solana", sono_stdprograms are not affected.It also addresses a couple of comments from #136:
entrypointmacro in favour ofentrypoint_with_allocator_and_panic_handlerno_allocatormacro in favour ofstatic_allocatorfeature(const_mut_refs)cc: @publicqi