feat: build and send block footer#570
Merged
Merged
Conversation
ksn6
force-pushed
the
send-block-footer
branch
from
5711644 to
a8e3ef3
Compare
ksn6
requested review from
AshwinSekar,
apfitzge,
bw-solana,
carllin and
wen-coding
AshwinSekar
reviewed
Oct 23, 2025
|
|
||
| // TODO: insert block footer | ||
| // Construct and send the block footer | ||
| let footer = produce_block_footer(); |
Contributor
There was a problem hiding this comment.
awesome, this turned out very clean! FYI @akhi3030 you can plug in your rewards container here to populate the aggregates in the footer.
For the finalized certificate I imagine we can have something lightweight that can be updated on VotorEvent::Finalized. Can probably even live inside the rewards container and we can add it to the footer
Contributor
There was a problem hiding this comment.
perfect, this looks nice and straightforward.
AshwinSekar
reviewed
Oct 23, 2025
ksn6
force-pushed
the
send-block-footer
branch
from
dc545c3 to
b433739
Compare
AshwinSekar
reviewed
Oct 23, 2025
apfitzge
reviewed
Oct 24, 2025
AshwinSekar
reviewed
Oct 24, 2025
ksn6
force-pushed
the
send-block-footer
branch
from
b6bb1ee to
37b5b73
Compare
AshwinSekar
approved these changes
Oct 24, 2025
AshwinSekar
pushed a commit
to AshwinSekar/alpenglow
that referenced
this pull request
Feb 23, 2026
Construct and disseminate the block footer. In a follow-up PR, we'll parse the footer in replay. This PR addresses solana-foundation/solana-improvement-documents#307.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Summary of Changes
Construct and disseminate the block footer. In a follow-up PR, we'll parse the footer in replay.
This PR addresses solana-foundation/solana-improvement-documents#307.