refactor: additional feedback for #360

[akhi3030]

#360 was accidentally merged and not all review comments were addressed. This PR addresses the remaining comments.

[qkniep]

LGTM

Just a sanity check for me: Whether we set has_fast_finalize for genesis to true or false is completely arbitrary because we have to treat genesis separately anyways, right?

[akhi3030]

LGTM

Just a sanity check for me: Whether we set has_fast_finalize for genesis to true or false is completely arbitrary because we have to treat genesis separately anyways, right?

CC: @AshwinSekar and @bw-solana as I think they might have the best context.

[wen-coding]

LGTM
Just a sanity check for me: Whether we set has_fast_finalize for genesis to true or false is completely arbitrary because we have to treat genesis separately anyways, right?

CC: @AshwinSekar and @bw-solana as I think they might have the best context.

Hmm yeah, on second thought it doesn't matter much what we set here, because we have no certs for genesis, the actual behavior would be the same. It just is a bit better conceptually because we really have no fast finalize cert for genesis.

[bw-solana]

yeah, we special case this for 'parent ready' as well