Skip to content

Removes Option wrapper on AccountsDbConfig::bank_hash_details_dir#9997

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:accounts-db-config/bank-hash-details-dir
Jan 14, 2026
Merged

Removes Option wrapper on AccountsDbConfig::bank_hash_details_dir#9997
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:accounts-db-config/bank-hash-details-dir

Conversation

@brooksprumo
Copy link
Copy Markdown

Problem

The AccountsDbConfig::bank_hash_details_dir field is Option-wrapped only because Rust in versions 1.90 and older does not have a way to create a PathBuf in const contexts, which is needed for the ACCOUNTS_DB_CONFIG_FOR_TESTING/BENCHMARKS constants.

Summary of Changes

We're now on Rust 1.91.1, so remove the Option wrapper.

@brooksprumo brooksprumo self-assigned this Jan 13, 2026
@brooksprumo brooksprumo force-pushed the accounts-db-config/bank-hash-details-dir branch from e4f9b66 to 0736365 Compare January 13, 2026 20:56
@brooksprumo brooksprumo marked this pull request as ready for review January 13, 2026 21:21
@brooksprumo brooksprumo requested a review from roryharr January 13, 2026 21:21
@brooksprumo brooksprumo force-pushed the accounts-db-config/bank-hash-details-dir branch from 0736365 to 5cff551 Compare January 14, 2026 15:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.5%. Comparing base (bba10d8) to head (5cff551).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9997     +/-   ##
=========================================
- Coverage    82.5%    82.5%   -0.1%     
=========================================
  Files         844      844             
  Lines      316757   316753      -4     
=========================================
- Hits       261599   261583     -16     
- Misses      55158    55170     +12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo brooksprumo added this pull request to the merge queue Jan 14, 2026
Merged via the queue into anza-xyz:master with commit cd9b189 Jan 14, 2026
47 checks passed
@brooksprumo brooksprumo deleted the accounts-db-config/bank-hash-details-dir branch January 14, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants