Removes Option wrapper on AccountsDbConfig::bank_hash_details_dir#9997
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jan 14, 2026
Merged
Conversation
e4f9b66 to
0736365
Compare
0736365 to
5cff551
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9997 +/- ##
=========================================
- Coverage 82.5% 82.5% -0.1%
=========================================
Files 844 844
Lines 316757 316753 -4
=========================================
- Hits 261599 261583 -16
- Misses 55158 55170 +12 🚀 New features to boost your workflow:
|
roryharr
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
AccountsDbConfig::bank_hash_details_dirfield isOption-wrapped only because Rust in versions 1.90 and older does not have a way to create a PathBuf in const contexts, which is needed for theACCOUNTS_DB_CONFIG_FOR_TESTING/BENCHMARKSconstants.Summary of Changes
We're now on Rust 1.91.1, so remove the Option wrapper.