Bump bls-signatures to v3.0#9967
Merged
samkim-crypto merged 9 commits intoanza-xyz:masterfrom Jan 15, 2026
Merged
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
c0f8923 to
5f77211
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9967 +/- ##
========================================
Coverage 82.5% 82.5%
========================================
Files 846 844 -2
Lines 316799 316352 -447
========================================
- Hits 261573 261205 -368
+ Misses 55226 55147 -79 🚀 New features to boost your workflow:
|
zz-sol
approved these changes
Jan 15, 2026
samkim-crypto
added a commit
to anza-xyz/alpenglow
that referenced
this pull request
Jan 27, 2026
#### Problem `solana-bls-signatures` in agave was upgraded in v3 (anza-xyz/agave#9967). The main change in API - signature verification functions now return `Result<(), Err>` instead of `Result<bool, Err>` - (BLS) `Keypair` now holds (BLS) `PubkeyAffine` instead of (BLS) `Pubkey`, so when we want to extract `Pubkey`, we need to add an extra `.into()`. #### Summary of Changes Upgrading to v3 in alpenglow. Fixes # <!-- OPTIONAL: Feature Gate Issue: # --> <!-- Don't forget to add the "feature-gate" label -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Next major release of
bls-signaturesis out.Summary of Changes
Upgrade to
bls-signaturesv3.0.I simplified the logic a little in the vote program with the improved API.
I had to make some edits in the other crates because a
Keypairnow holdsPubkeyAffineas the public key type rather thanPubkey, so I added manual conversions, but this should be quite straightforward.Fixes #