Skip to content

Bump bls-signatures to v3.0#9967

Merged
samkim-crypto merged 9 commits intoanza-xyz:masterfrom
samkim-crypto:bump-bls-signatures
Jan 15, 2026
Merged

Bump bls-signatures to v3.0#9967
samkim-crypto merged 9 commits intoanza-xyz:masterfrom
samkim-crypto:bump-bls-signatures

Conversation

@samkim-crypto
Copy link
Copy Markdown

@samkim-crypto samkim-crypto commented Jan 13, 2026

Problem

Next major release of bls-signatures is out.

Summary of Changes

Upgrade to bls-signatures v3.0.

I simplified the logic a little in the vote program with the improved API.

I had to make some edits in the other crates because a Keypair now holds PubkeyAffine as the public key type rather than Pubkey, so I added manual conversions, but this should be quite straightforward.

Fixes #

@mergify
Copy link
Copy Markdown

mergify Bot commented Jan 13, 2026

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.5%. Comparing base (386c635) to head (f3cb903).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9967    +/-   ##
========================================
  Coverage    82.5%    82.5%            
========================================
  Files         846      844     -2     
  Lines      316799   316352   -447     
========================================
- Hits       261573   261205   -368     
+ Misses      55226    55147    -79     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samkim-crypto samkim-crypto requested a review from zz-sol January 13, 2026 13:25
@samkim-crypto samkim-crypto marked this pull request as ready for review January 13, 2026 13:25
@samkim-crypto samkim-crypto added this pull request to the merge queue Jan 15, 2026
Merged via the queue into anza-xyz:master with commit 08cdc90 Jan 15, 2026
58 checks passed
@samkim-crypto samkim-crypto deleted the bump-bls-signatures branch January 15, 2026 02:51
samkim-crypto added a commit to anza-xyz/alpenglow that referenced this pull request Jan 27, 2026
#### Problem

`solana-bls-signatures` in agave was upgraded in v3
(anza-xyz/agave#9967).

The main change in API
- signature verification functions now return `Result<(), Err>` instead
of `Result<bool, Err>`
- (BLS) `Keypair` now holds (BLS) `PubkeyAffine` instead of (BLS)
`Pubkey`, so when we want to extract `Pubkey`, we need to add an extra
`.into()`.

#### Summary of Changes

Upgrading to v3 in alpenglow.

Fixes #
<!-- OPTIONAL: Feature Gate Issue: # -->
<!-- Don't forget to add the "feature-gate" label -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants