Give SigVerify and ShredFetch threads unique names#98
Merged
steviez merged 2 commits intoanza-xyz:masterfrom Mar 6, 2024
Merged
Give SigVerify and ShredFetch threads unique names#98steviez merged 2 commits intoanza-xyz:masterfrom
steviez merged 2 commits intoanza-xyz:masterfrom
Conversation
steviez
changed the title
steviez
force-pushed
the
sfs_thread_names
branch
from
7d41d82 to
4758844
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 838 838
Lines 225941 225940 -1
=========================================
- Hits 184945 184884 -61
- Misses 40996 41056 +60 |
bw-solana
approved these changes
Mar 6, 2024
| .unwrap() | ||
| } | ||
|
|
||
| fn verifier_services<T: SigVerifier + 'static + Send>( |
Author
There was a problem hiding this comment.
Good question - my guess is this used to contain multiple thread handles but got refactored to only include the single thread that it currently does
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
- solTvuFetchPmod ==> solTvuPktMod + solTvuRepPktMod - solSigVerifier ==> solSigVerTpu + solSigVerTpuVot
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
Allow selection of the active attack via RPC. Also, ignore write program test in local cluster for now. Refactored by: Illia Bobyr <illia.bobyr@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #34 for context
Summary of Changes
solTvuFetchPmod==>solTvuPktMod+solTvuRepPktModsolSigVerifier==>solSigVerTpu+solSigVerTpuVot