avoid using recv in sigverify#9727
Draft
KirillLykov wants to merge 1 commit intoanza-xyz:masterfrom
Draft
Conversation
b58cbad to
79f6280
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9727 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 854 854
Lines 320932 320941 +9
=======================================
+ Hits 265512 265530 +18
+ Misses 55420 55411 -9 🚀 New features to boost your workflow:
|
79f6280 to
9acfd12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current version uses
recv_timeoutwhich internally relies on the parking/waiking up mechanism.This PR is draft because it should land after #9732
Summary of Changes
We use looping with only
try_recvinstead to reduce synchronization overhead. See profiler output: