Upstream Alpenglow votor and votor-messages#9518
Conversation
carllin
requested review from
AshwinSekar,
bw-solana,
steviez and
wen-coding
carllin
changed the title
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Agreed with Wen - this PR will require some cleanup to "undo" stuff that has changed in Agave (crate renames, introduction of agave-unstable-api, etc)
carllin
force-pushed
the
upstreamvotor
branch
15 times, most recently
from
7b36e7d to
d7ecc6e
Compare
|
PR is best reviewed commit by commit starting with "Fixup dependencies"
@wen-coding tagged the two commits in particular that brought in your changes that would be good to have your eyes on |
carllin
force-pushed
the
upstreamvotor
branch
6 times, most recently
from
f5fcc44 to
ee67016
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9518 +/- ##
========================================
Coverage 82.5% 82.6%
========================================
Files 844 844
Lines 316757 316591 -166
========================================
- Hits 261599 261572 -27
+ Misses 55158 55019 -139 🚀 New features to boost your workflow:
|
carllin
force-pushed
the
upstreamvotor
branch
3 times, most recently
from
0c4b8f9 to
19b17f9
Compare
carllin
force-pushed
the
upstreamvotor
branch
4 times, most recently
from
1fd2e0c to
5fedc3b
Compare
AshwinSekar
force-pushed
the
upstreamvotor
branch
from
5fedc3b to
eb75295
Compare
| pub(crate) const fn certificate_limits_and_vote_types( | ||
| cert_type: &CertificateType, | ||
| ) -> (f64, Vote, Option<Vote>) { | ||
| ) -> (f64, &'static [VoteType]) { |
There was a problem hiding this comment.
a recent change in the votor repo changes these to a newly created Fraction type. We'll get that ported over in the next upstream
AshwinSekar
force-pushed
the
upstreamvotor
branch
from
eb75295 to
ae6d5ba
Compare
|
Thanks steve, addressed your comments here ae6d5ba Will cherry-pick these fixes back to the alpenglow repo once we're done to keep things in sync |
|
changes outside of I'm in favor of fixing anything offensive but not dragging on nits so we can get it in. There will be plenty of follow-ups and bug fixes once this gets fired up. |
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
I'm in favor of fixing anything offensive but not dragging on nits so we can get it in.
Whose dragging 😉
There will be plenty of follow-ups and bug fixes once this gets fired up.
Yup, we can keep kicking the can but we need to make sure we budget audit/review/cleanup/docs/etc into the time budget when we give answers to "wen Alpengow"
Haha morning coffee has me coming out guns blazing. Appreciate your review 🙏
Definitely. Refuse to ship garbage |
AshwinSekar
force-pushed
the
upstreamvotor
branch
from
ae6d5ba to
437f3a4
Compare
) #### Problem latest upstream to agave had some pr feedback that was addressed anza-xyz/agave#9518 #### Summary of Changes cherry-pick the feedback changes here to eliminate 2 way divergence
…nza-xyz#674) latest upstream to agave had some pr feedback that was addressed anza-xyz/agave#9518 cherry-pick the feedback changes here to eliminate 2 way divergence
6 participants
Problem
There is a two way divergence between the votor and votor-messages crates in Agave and Alpenglow repo
Summary of Changes
Fix the divergence by overwriting these crates from the latest from Alpenglow (- in progress features)